Skip to content

chore: Update argocd-operator to latest #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

svghadi
Copy link
Member

@svghadi svghadi commented Jul 26, 2025

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:
This update brings in new features from argocd-operator

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label Jul 26, 2025
@openshift-ci openshift-ci bot requested review from chetan-rns and wtam2018 July 26, 2025 10:49

sigs.k8s.io/controller-runtime => sigs.k8s.io/controller-runtime v0.19.1
)
replace k8s.io/client-go => k8s.io/client-go v0.33.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managed to remove most of the replace statements 🕺. However, one of the dependencies still expects client-go at version v0.12.0, which doesn't exist. So we need to explicitly add a replace directive to use the latest version instead.

@svghadi
Copy link
Member Author

svghadi commented Jul 28, 2025

/retest

anandf
anandf previously approved these changes Jul 28, 2025
@jgwest
Copy link
Collaborator

jgwest commented Jul 28, 2025

/retest

Failure is likely this (race condition in product, not a test bug) #909

@svghadi
Copy link
Member Author

svghadi commented Jul 29, 2025

/lgtm

Copy link

openshift-ci bot commented Jul 29, 2025

@svghadi: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@varshab1210
Copy link
Member

/lgtm
/approve

Copy link

openshift-ci bot commented Jul 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: varshab1210

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

svghadi added 2 commits July 29, 2025 15:45
Signed-off-by: Siddhesh Ghadi <[email protected]>
Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi svghadi force-pushed the update-argocd-operator branch from 106a7f1 to 366fb85 Compare July 29, 2025 10:15
@openshift-ci openshift-ci bot removed the lgtm label Jul 29, 2025
Copy link

openshift-ci bot commented Jul 29, 2025

New changes are detected. LGTM label has been removed.

svghadi added 2 commits July 29, 2025 16:59
Signed-off-by: Siddhesh Ghadi <[email protected]>
Copy link

openshift-ci bot commented Jul 29, 2025

@svghadi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit bd33d91 link true /test unit
ci/prow/v4.14-e2e bd33d91 link true /test v4.14-e2e
ci/prow/v4.14-kuttl-parallel bd33d91 link true /test v4.14-kuttl-parallel
ci/prow/v4.14-kuttl-sequential bd33d91 link true /test v4.14-kuttl-sequential
ci/prow/v4.17-e2e bd33d91 link true /test v4.17-e2e
ci/prow/v4.17-kuttl-sequential bd33d91 link true /test v4.17-kuttl-sequential
ci/prow/v4.17-kuttl-parallel bd33d91 link true /test v4.17-kuttl-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants