-
Notifications
You must be signed in to change notification settings - Fork 65
RHDHPAI-493: New Developer Sandbox RHDH Internal Plugin #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHDHPAI-493: New Developer Sandbox RHDH Internal Plugin #409
Conversation
Changed Packages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, also if I wasn't asked I quickly looked into this. Nice work 👍
I just like to recommend to use Material UI v4 or MUI v5, not both. You can do it and Backstage core components still use MUI v4. But I would avoid mixing them. :)
All our other other plugins uses MUI v5. Also not v6. It might work, but it could also result in issues when running later as a dynamic plugin in RHDH because RHDH dynamic plugins handles MUI as a shared library. So I guess you will get MUI v5 at runtime. 🤷♂️
But at the end, its up to you. The screenshot looks really nice. 😏
workspaces/sandbox/plugins/sandbox/src/components/SandboxActivities/SandboxActivitiesCard.tsx
Outdated
Show resolved
Hide resolved
...paces/sandbox/plugins/sandbox/src/components/SandboxActivities/SandboxActivitiesFeatured.tsx
Outdated
Show resolved
Hide resolved
...paces/sandbox/plugins/sandbox/src/components/SandboxActivities/SandboxActivitiesFeatured.tsx
Outdated
Show resolved
Hide resolved
workspaces/sandbox/plugins/sandbox/src/components/SandboxCatalog/SandboxCatalogFooter.tsx
Outdated
Show resolved
Hide resolved
Thanks, @Lucifergene , It looks great! I have a few questions: Home Page (design):
![]()
Mobile Verification Modal (design):
![]()
Verification Code Modal (design):
Access Code Modal (design):
Dark Mode:
Activities Page (design):
|
4f29a1e
to
7c3d171
Compare
workspaces/sandbox/plugins/sandbox/src/api/RegistrationBackendClient.tsx
Show resolved
Hide resolved
Signed-off-by: Lucifergene <[email protected]>
Signed-off-by: Lucifergene <[email protected]>
Signed-off-by: Lucifergene <[email protected]>
Signed-off-by: Lucifergene <[email protected]>
Signed-off-by: Lucifergene <[email protected]>
Signed-off-by: Lucifergene <[email protected]>
fb13491
to
225a7c9
Compare
Signed-off-by: Lucifergene <[email protected]>
@Lucifergene This looks great 🎆 , I have added few comments, PTAL. FYI, Sonarcloud issues has to be fixed too.
|
Thanks @Eswaraiahsapram |
Signed-off-by: Lucifergene <[email protected]>
Signed-off-by: Lucifergene <[email protected]>
Signed-off-by: Lucifergene <[email protected]>
Signed-off-by: Lucifergene <[email protected]>
Signed-off-by: Lucifergene <[email protected]>
|
yes, as the verification flow is not shown to everyone. Only some users would get it. Others would directly get signed up and sent to the cluster url. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Developer Sandbox RHDH Internal Plugin
Screenshots
Modals
Video
Tab-.object.Object._.RHDH.mp4
Sprint Demo:
https://github.com/user-attachments/assets/9f2abd7b-4a25-4dd1-b7a2-f07d08e49cd4
✔️ Checklist