orchestrator: add endpoint for calling mutation ExecuteAfter#425
orchestrator: add endpoint for calling mutation ExecuteAfter#425ydayagi wants to merge 1 commit into
Conversation
|
There was a problem hiding this comment.
Do we need the as string here? I guess not thanks to the check on line 151
There was a problem hiding this comment.
@mareklibra line 151 helps for the case that it is undefined not for the type. because it is of type unknown (the field orchestratorAssessmentInstanceId) I get compile error. so, yes, it is needed.
There was a problem hiding this comment.
This part looks suspicious, can you please confirm it is as expected?
When looking at changes around https://github.com/redhat-developer/rhdh-plugins/pull/425/files#diff-dfd9240b67dcd5abbff3560a8d0f341802d928a817c13e2350a999bb2751d5fdR588 , there seems to be just an addition of fields but the change here puts executeWorkflowRequestDTO.inputData into a sub-property.
There was a problem hiding this comment.
indeed this change is required. this is the new implementation in sonataflow. if you have workflowdata field then it is treated as the input to the workflow execution and all the rest is stored without using it. If you do not have workflowdata then the whole variables object is treated as the input to the workflow execution. putting the input in the workflowdata field enables us to pass orchestratorAssessmentInstanceId into variables and having it stored and read when querying the workflow instance/execution/run.
christoph-jerolimov
changed the title
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
FLPATH-2027 https://issues.redhat.com/browse/FLPATH-2027 Signed-off-by: Yaron Dayagi <ydayagi@redhat.com>
|
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
2 participants
DO NOT MERGE BEFORE #306. This one depends on it.