ci: allow version string as release line parameter for version bump specific versions #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecific versions Signed-off-by: Christoph Jerolimov <[email protected]>
christoph-jerolimov
requested review from
BethGriggs,
nickboldt,
kim-tsao,
04kash and
coreydaley
as code owners
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
I understand that we want update Backstage mostly to the latest stable or pre-release version.
With the interim PR #527 I added another option (1.36.1) as a specific version to the Version bump workflow.
The workflow updates the workspace correctly, but the branch_name, changeset and PR title was not created correctly, because the set-release-name script expects just two parameters:
mainandnextals release line.Example:
This PR adds an else case if the value is neither
mainnornextso that we can update also to specific versions with the Version Bump script.When this is accepted I can raise a similar PR for https://github.com/backstage/community-plugins/blob/main/scripts/ci/set-release-name.js
✔️ Checklist