Make esbuild to produce bundled & minified VSIX #4584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrubezhny
force-pushed
the
fix-esbuild-to-produce-bundle
branch
15 times, most recently
from
6ebcdf0 to
cc8dbde
Compare
vrubezhny
force-pushed
the
fix-esbuild-to-produce-bundle
branch
9 times, most recently
from
44c567e to
90b3305
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4584 +/- ##
===========================================
+ Coverage 32.37% 44.51% +12.14%
===========================================
Files 85 100 +15
Lines 6505 8170 +1665
Branches 1349 1707 +358
===========================================
+ Hits 2106 3637 +1531
- Misses 4399 4533 +134 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
vrubezhny
force-pushed
the
fix-esbuild-to-produce-bundle
branch
3 times, most recently
from
2365001 to
39f4aeb
Compare
datho7561
reviewed
Nov 15, 2024
datho7561
reviewed
Nov 15, 2024
vrubezhny
force-pushed
the
fix-esbuild-to-produce-bundle
branch
3 times, most recently
from
39b38f8 to
8f1e748
Compare
datho7561
requested changes
Nov 18, 2024
vrubezhny
force-pushed
the
fix-esbuild-to-produce-bundle
branch
from
8f1e748 to
2fb7ca9
Compare
datho7561
previously approved these changes
Nov 18, 2024
vrubezhny
force-pushed
the
fix-esbuild-to-produce-bundle
branch
from
2fb7ca9 to
7361dff
Compare
|
@lgrossma Could you please take a look at UI tests: |
vrubezhny
force-pushed
the
fix-esbuild-to-produce-bundle
branch
5 times, most recently
from
90e09bc to
cf3a5a1
Compare
|
The Public UI tests are restored. |
vrubezhny
force-pushed
the
fix-esbuild-to-produce-bundle
branch
from
cf3a5a1 to
cc4cefc
Compare
This fix makes 'esbuild' to produce the bundled and minified VSIX extension archive, free of unneeded dependency modules, when the packaging is started with `vsce package`. On other hand, when building with `npm install && npm run build` and testing with `npm test` the extension file structure is kept unchange and the trunspiled scripts aren't minified, so the unit testing and coverage tests work as usual. Note: `npm install` is needed to be executed after executing `vsce package` as the last one clears the `node_modules/` of the depencencies not needed in production. Fixes redhat-developer#4226 Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny
force-pushed
the
fix-esbuild-to-produce-bundle
branch
from
cc4cefc to
8201122
Compare
|
@datho7561 @msivasubramaniaan Thanks for the reviews and @lgrossma for helping with the tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix makes 'esbuild' to produce the bundled and minified VSIX extension archive,
free of unneeded dependency modules, when the packaging is started with
vsce package.On other hand, when building with
npm install && npm run buildand testing withnpm testthe extension file structure is kept unchange and the trunspiled scripts aren't minified,
so the unit testing and coverage tests work as usual.
Note:
npm installis needed to be executed after executingvsce packageas the last oneclears the
node_modules/of the dependencies not needed in production.Fixes #4226