feat: add benchmark repeatability analysis with Coefficient of Variation#112
Draft
maryamtahhan wants to merge 1 commit intoredhat-et:mainfrom
Draft
feat: add benchmark repeatability analysis with Coefficient of Variation#112maryamtahhan wants to merge 1 commit intoredhat-et:mainfrom
maryamtahhan wants to merge 1 commit intoredhat-et:mainfrom
Conversation
Add comprehensive repeatability analysis tooling to measure benchmark consistency using Coefficient of Variation (CV) metrics. New features: - analyze_repeatability.py: Calculate CV for metrics across multiple runs - Automatic grouping by platform, model, cores, TP, vLLM version, concurrency - Repeatability grading (Excellent/Good/Acceptable/Poor) based on CV thresholds - Markdown and JSON report generation with detailed CV tables and rankings - Dashboard utilities for integrating CV metrics into visualizations CV interpretation: - CV < 1%: Excellent (ideal for regression testing) - CV 1-3%: Good (suitable for performance comparisons) - CV 3-5%: Acceptable (moderate variance) - CV > 5%: Poor (high variance, unreliable results) Metrics analyzed: - Request latency (mean, P90, P95) - TTFT (mean, P90, P95) - TPoT/ITL (mean, P90, P95) - Output throughput Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive repeatability analysis tooling to measure benchmark consistency using Coefficient of Variation (CV) metrics.
New features:
CV interpretation:
Metrics analyzed: