Skip to content

Dashboard integration - address coderabitai comments #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maryamtahhan wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Dashboard integration - address coderabitai comments #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0639bdc
fix: address CodeRabbit AI review comments
maryamtahhan Apr 2, 2026
53411d5
fix: remove hardcoded values and fix cleanup script paths
maryamtahhan Apr 2, 2026
9bbaf34
fix: improve Ansible playbook portability and documentation accuracy
maryamtahhan Apr 2, 2026
653aed9
fix: revert port detection to original ss/netstat approach and fix st…
maryamtahhan Apr 2, 2026
1b1ac3d
fix: simplify stop-grafana compose detection and prioritize podman-co…
maryamtahhan Apr 2, 2026
5bb7508
fix: match compose tool priority order between start and stop playbooks
maryamtahhan Apr 2, 2026
5159620
fix: revert vLLM dashboard to use hardcoded datasource UID
maryamtahhan Apr 2, 2026
1657329
fix: update vLLM dashboard to use correct datasource UID
maryamtahhan Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion automation/test-execution/ansible/llm-benchmark-auto.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,7 @@
tasks_from: stop
vars:
results_path: "{{ playbook_dir }}/../../../results/llm/{{ test_model | replace('/', '__') }}/{{ workload_type }}-{{ hostvars['localhost']['test_run_id'] }}/{{ core_configuration.name }}"
metrics_collection_duration: "{{ hostvars['localhost']['estimated_test_duration'] | default(60) }}"
enable_vllm_metrics_collection: true
delegate_to: localhost
become: false
Expand Down Expand Up @@ -515,7 +516,8 @@
- block:
- name: Get tunnel PID
ansible.builtin.shell: |
lsof -ti :8000 -sTCP:LISTEN | head -1
# Only kill SSH tunnel processes, not vLLM server or other services
pgrep -f "ssh.*-L.*8000:localhost:8000" | head -1
Comment on lines +519 to +520
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

SSH tunnel pattern inconsistent with start-grafana.yml—may match unintended tunnels.

The pattern ssh.*-L.*8000:localhost:8000 here lacks hostname anchoring, while start-grafana.yml (lines 430, 451) uses ssh.*8000:localhost:8000.*{{ dut_hostname }}. On systems with multiple SSH tunnels to different hosts, this could kill the wrong tunnel.

Consider adding hostname anchoring for consistency:

Proposed fix 
         - name: Get tunnel PID
           ansible.builtin.shell: |
-            # Only kill SSH tunnel processes, not vLLM server or other services
-            pgrep -f "ssh.*-L.*8000:localhost:8000" | head -1
+            # Only kill SSH tunnel processes for the DUT, not other tunnels
+            pgrep -f "ssh.*-L.*8000:localhost:8000.*{{ groups['dut'][0] }}" | head -1
           register: tunnel_pid_check
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Only kill SSH tunnel processes, not vLLM server or other services
pgrep -f "ssh.*-L.*8000:localhost:8000" | head -1
# Only kill SSH tunnel processes for the DUT, not other tunnels
pgrep -f "ssh.*-L.*8000:localhost:8000.*{{ groups['dut'][0] }}" | head -1
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@automation/test-execution/ansible/llm-benchmark-auto.yml` around lines 519 -
520, The pgrep pattern "ssh.*-L.*8000:localhost:8000" can match tunnels to other
hosts; update the pgrep invocation used here to include the DUT hostname anchor
(same approach as in start-grafana.yml) so it only matches the specific tunnel
for the target host — for example, change the pattern used by the pgrep call
that searches for the SSH tunnel to include "8000:localhost:8000.*{{
dut_hostname }}" (or the equivalent runtime variable like ${dut_hostname}) so
only the intended SSH process is selected.

register: tunnel_pid_check
failed_when: false
changed_when: false
Expand Down
18 changes: 17 additions & 1 deletion automation/test-execution/ansible/publish-existing-results.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,33 @@
- requested_cores is defined
fail_msg: "Missing required variables. Provide: test_model, workload_type, test_run_id, requested_cores"

- name: Search for test-metadata.json to find core_config_name
ansible.builtin.find:
paths: "{{ playbook_dir }}/../../../results/llm/{{ test_model | replace('/', '__') }}/{{ workload_type }}-{{ test_run_id }}"
patterns: "test-metadata.json"
recurse: true
register: metadata_search
when: core_config_name is not defined

- name: Load core_config_name from metadata if found
ansible.builtin.set_fact:
core_config_name: "{{ (lookup('file', metadata_search.files[0].path) | from_json).core_config_name }}"
when:
- core_config_name is not defined
- metadata_search.matched > 0

- name: Set core configuration if not provided
ansible.builtin.set_fact:
core_configuration:
cores: "{{ requested_cores }}"
tensor_parallel: 1
numa_node: 0
name: "{{ core_config_name | default(requested_cores | string + 'cores-numa0-tp1') }}"
when: core_configuration is not defined

- name: Build results path
ansible.builtin.set_fact:
results_path: "{{ playbook_dir }}/../../../results/llm/{{ test_model | replace('/', '__') }}/{{ workload_type }}-{{ test_run_id }}/{{ requested_cores }}cores-numa{{ core_configuration.numa_node | default(0) }}-tp{{ core_configuration.tensor_parallel | default(1) }}"
results_path: "{{ playbook_dir }}/../../../results/llm/{{ test_model | replace('/', '__') }}/{{ workload_type }}-{{ test_run_id }}/{{ core_configuration.name | default(core_config_name) | default(requested_cores | string + 'cores-numa' + (core_configuration.numa_node | default(0) | string) + '-tp' + (core_configuration.tensor_parallel | default(1) | string)) }}"

- name: Display publishing configuration
ansible.builtin.debug:
Expand Down
8 changes: 4 additions & 4 deletions automation/test-execution/ansible/roles/metrics_publisher/templates/prometheus_metrics.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ guidellm_itl_ms_p95{ {{ labels }} } {{ benchmark.metrics.inter_token_latency_ms.
guidellm_itl_ms_p99{ {{ labels }} } {{ benchmark.metrics.inter_token_latency_ms.successful.percentiles.p99 | default(0) }}

# End-to-End Request Latency in milliseconds (convert from seconds)
guidellm_e2e_latency_ms_mean{ {{ labels }} } {{ (benchmark.metrics.request_latency.successful.mean * 1000) | default(0) }}
guidellm_e2e_latency_ms_p50{ {{ labels }} } {{ (benchmark.metrics.request_latency.successful.percentiles.p50 * 1000) | default(0) }}
guidellm_e2e_latency_ms_p95{ {{ labels }} } {{ (benchmark.metrics.request_latency.successful.percentiles.p95 * 1000) | default(0) }}
guidellm_e2e_latency_ms_p99{ {{ labels }} } {{ (benchmark.metrics.request_latency.successful.percentiles.p99 * 1000) | default(0) }}
guidellm_e2e_latency_ms_mean{ {{ labels }} } {{ (benchmark.metrics.request_latency.successful.mean | default(0)) * 1000 }}
guidellm_e2e_latency_ms_p50{ {{ labels }} } {{ (benchmark.metrics.request_latency.successful.percentiles.p50 | default(0)) * 1000 }}
guidellm_e2e_latency_ms_p95{ {{ labels }} } {{ (benchmark.metrics.request_latency.successful.percentiles.p95 | default(0)) * 1000 }}
guidellm_e2e_latency_ms_p99{ {{ labels }} } {{ (benchmark.metrics.request_latency.successful.percentiles.p99 | default(0)) * 1000 }}

# Request Statistics
guidellm_total_requests{ {{ labels }} } {{ benchmark.metrics.request_totals.total | default(0) }}
Expand Down
2 changes: 1 addition & 1 deletion automation/test-execution/ansible/roles/vllm_metrics_collector/tasks/stop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
- name: Wait for metrics collection to complete
ansible.builtin.wait_for:
path: "{{ results_path }}/vllm-metrics.json"
timeout: 30
timeout: "{{ (metrics_collection_duration | default(60) | int) + 30 }}"
delegate_to: localhost
become: false
ignore_errors: true
Expand Down
53 changes: 38 additions & 15 deletions automation/test-execution/ansible/start-grafana.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,43 +60,59 @@

- name: Auto-detect compose tool
block:
- name: Check for podman-compose
ansible.builtin.command: podman-compose --version
register: podman_compose_check
failed_when: false
changed_when: false

- name: Check for docker-compose
ansible.builtin.command: docker-compose --version
register: docker_compose_check
failed_when: false
changed_when: false

- name: Check for podman-compose
ansible.builtin.command: podman-compose --version
register: podman_compose_check
- name: Check for docker compose (CLI v2)
ansible.builtin.command: docker compose version
register: docker_cli_compose_check
failed_when: false
changed_when: false

- name: Set compose command (podman-compose)
ansible.builtin.set_fact:
compose_cmd: podman-compose
runtime_name: Podman
when: podman_compose_check.rc == 0

- name: Set compose command (docker-compose)
ansible.builtin.set_fact:
compose_cmd: docker-compose
runtime_name: Docker
when: docker_compose_check.rc == 0
when:
- podman_compose_check.rc != 0
- docker_compose_check.rc == 0

- name: Set compose command (podman-compose)
- name: Set compose command (docker compose CLI v2)
ansible.builtin.set_fact:
compose_cmd: podman-compose
runtime_name: Podman
compose_cmd: docker compose
runtime_name: Docker
when:
- podman_compose_check.rc != 0
- docker_compose_check.rc != 0
- podman_compose_check.rc == 0
- docker_cli_compose_check.rc == 0

- name: Fail if no compose tool found
ansible.builtin.fail:
msg: |
Neither docker-compose nor podman-compose found!
Neither podman-compose, docker-compose, nor docker compose found!

Install one of the following:
- Docker Desktop (includes docker-compose)
- Docker Desktop (includes docker-compose or docker compose)
- podman-compose: pip3 install podman-compose
when:
- docker_compose_check.rc != 0
- podman_compose_check.rc != 0
- docker_compose_check.rc != 0
- docker_cli_compose_check.rc != 0
when: compose_cmd_override == ""

# ========================================================================
Expand Down Expand Up @@ -240,11 +256,18 @@
when: is_macos
register: datasource_update_macos

- name: Read current datasource version
ansible.builtin.shell: |
grep -oP 'version: \K\d+' "{{ grafana_dir }}/provisioning/datasources/prometheus.yaml" || echo "1"
register: current_version
changed_when: false
when: datasource_update_linux.changed or datasource_update_macos.changed

- name: Bump datasource version to force reload
ansible.builtin.replace:
path: "{{ grafana_dir }}/provisioning/datasources/prometheus.yaml"
regexp: "version: \\d+"
replace: "version: {{ 99 | random(start=10) }}"
replace: "version: {{ current_version.stdout | int + 1 }}"
Comment on lines +259 to +270
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify if the playbook is expected to run on macOS and check grep capabilities

# Check if there are any Darwin-specific conditions in the playbook
rg -n "Darwin|macos|macOS" automation/test-execution/ansible/start-grafana.yml

# Check if GNU grep might be installed via Homebrew on typical macOS setups
echo "---"
echo "Note: On macOS, GNU grep can be installed via 'brew install grep' as 'ggrep'"

Repository: redhat-et/vllm-cpu-perf-eval

Length of output: 1019

Use portable grep syntax to avoid BSD grep -P incompatibility on macOS.

The grep -oP command fails on macOS (which uses BSD grep by default) since the -P flag is GNU-specific. The playbook runs on both Darwin and Linux (see lines 34–35), and the datasource version task executes on macOS when the datasource is updated. Replace with a portable alternative:

Proposed fix 
    - name: Read current datasource version
      ansible.builtin.shell: |
-       grep -oP 'version: \K\d+' "{{ grafana_dir }}/provisioning/datasources/prometheus.yaml" || echo "1"
+       grep -E 'version: [0-9]+' "{{ grafana_dir }}/provisioning/datasources/prometheus.yaml" | sed 's/.*version: //' | tr -d ' ' || echo "1"
       register: current_version
       changed_when: false
       when: datasource_update_linux.changed or datasource_update_macos.changed
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Read current datasource version
ansible.builtin.shell: |
grep -oP 'version: \K\d+' "{{ grafana_dir }}/provisioning/datasources/prometheus.yaml" || echo "1"
register: current_version
changed_when: false
when: datasource_update_linux.changed or datasource_update_macos.changed
- name: Bump datasource version to force reload
ansible.builtin.replace:
path: "{{ grafana_dir }}/provisioning/datasources/prometheus.yaml"
regexp: "version: \\d+"
replace: "version: {{ 99 | random(start=10) }}"
replace: "version: {{ current_version.stdout | int + 1 }}"
- name: Read current datasource version
ansible.builtin.shell: |
grep -E 'version: [0-9]+' "{{ grafana_dir }}/provisioning/datasources/prometheus.yaml" | sed 's/.*version: //' | tr -d ' ' || echo "1"
register: current_version
changed_when: false
when: datasource_update_linux.changed or datasource_update_macos.changed
- name: Bump datasource version to force reload
ansible.builtin.replace:
path: "{{ grafana_dir }}/provisioning/datasources/prometheus.yaml"
regexp: "version: \\d+"
replace: "version: {{ current_version.stdout | int + 1 }}"
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@automation/test-execution/ansible/start-grafana.yml` around lines 259 - 270,
The "Read current datasource version" task uses GNU-only grep -P which fails on
macOS; replace the shell command with a portable extractor such as awk to read
the version (e.g. use awk -F': ' '/version:/{print $2; exit}' "{{ grafana_dir
}}/provisioning/datasources/prometheus.yaml" || echo "1") so the task still
registers current_version and keeps changed_when: false and the same when
condition; keep the subsequent "Bump datasource version to force reload" replace
task unchanged (it will use current_version.stdout | int + 1).

when: datasource_update_linux.changed or datasource_update_macos.changed

- name: Display datasource configuration
Expand Down Expand Up @@ -287,7 +310,7 @@
register: container_logs
changed_when: false
failed_when: false
when: "'Up' not in container_status.stdout and 'running' not in container_status.stdout"
when: compose_up.rc != 0 or "Exited" in container_status.stdout or ("Up" not in container_status.stdout and "running" not in container_status.stdout)

- name: Display compose output
ansible.builtin.debug:
Expand Down Expand Up @@ -404,7 +427,7 @@
block:
- name: Check if tunnel already exists
ansible.builtin.shell: |
ps aux | grep "ssh.*8000:localhost:8000" | grep -v grep || true
ps aux | grep "ssh.*8000:localhost:8000.*{{ dut_hostname }}" | grep -v grep || true
register: existing_tunnel
changed_when: false

Expand All @@ -425,7 +448,7 @@

- name: Verify tunnel is active
ansible.builtin.shell: |
ps aux | grep "ssh.*8000:localhost:8000" | grep -v grep
ps aux | grep "ssh.*8000:localhost:8000.*{{ dut_hostname }}" | grep -v grep
register: tunnel_status
changed_when: false
failed_when: false
Expand Down
43 changes: 30 additions & 13 deletions automation/test-execution/ansible/stop-grafana.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
vars:
grafana_dir: "{{ playbook_dir }}/../grafana"
compose_project_name: vllm-monitoring
compose_file: "{{ 'docker-compose.macos.yml' if ansible_os_family == 'Darwin' else 'docker-compose.yml' }}"
# remove_volumes can be passed via -e "remove_volumes=true"
remove_volumes_flag: "{{ remove_volumes | default(false) | bool }}"

Expand All @@ -26,38 +27,54 @@

- name: Detect available compose tool
block:
- name: Check for podman-compose
ansible.builtin.command: podman-compose --version
register: podman_compose_check
failed_when: false
changed_when: false

- name: Check for docker-compose
ansible.builtin.command: docker-compose --version
register: docker_compose_check
failed_when: false
changed_when: false

- name: Check for podman-compose
ansible.builtin.command: podman-compose --version
register: podman_compose_check
- name: Check for docker compose (CLI v2)
ansible.builtin.command: docker compose version
register: docker_cli_compose_check
failed_when: false
changed_when: false

- name: Set compose command (podman-compose)
ansible.builtin.set_fact:
compose_cmd: podman-compose
runtime_name: Podman
when: podman_compose_check.rc == 0

- name: Set compose command (docker-compose)
ansible.builtin.set_fact:
compose_cmd: docker-compose
runtime_name: Docker
when: docker_compose_check.rc == 0
when:
- podman_compose_check.rc != 0
- docker_compose_check.rc == 0

- name: Set compose command (podman-compose)
- name: Set compose command (docker compose CLI v2)
ansible.builtin.set_fact:
compose_cmd: podman-compose
runtime_name: Podman
compose_cmd: docker compose
runtime_name: Docker
when:
- podman_compose_check.rc != 0
- docker_compose_check.rc != 0
- podman_compose_check.rc == 0
- docker_cli_compose_check.rc == 0

- name: Fail if no compose tool found
ansible.builtin.fail:
msg: "Neither docker-compose nor podman-compose found!"
msg: "Neither podman-compose, docker-compose, nor docker compose found!"
when:
- docker_compose_check.rc != 0
- podman_compose_check.rc != 0
- docker_compose_check.rc != 0
- docker_cli_compose_check.rc != 0

- name: Display detected configuration
ansible.builtin.debug:
Expand Down Expand Up @@ -119,14 +136,14 @@
block:
- name: Stop Grafana stack (preserving volumes)
ansible.builtin.command:
cmd: "{{ compose_cmd }} down"
cmd: "{{ compose_cmd }} -f {{ compose_file }} down"
chdir: "{{ grafana_dir }}"
register: compose_down
when: not remove_volumes_flag

- name: Stop Grafana stack (removing volumes)
ansible.builtin.command:
cmd: "{{ compose_cmd }} down -v"
cmd: "{{ compose_cmd }} -f {{ compose_file }} down -v"
chdir: "{{ grafana_dir }}"
register: compose_down_volumes
when: remove_volumes_flag
Expand All @@ -139,7 +156,7 @@

- name: Verify containers stopped
ansible.builtin.command:
cmd: "{{ compose_cmd }} ps"
cmd: "{{ compose_cmd }} -f {{ compose_file }} ps"
chdir: "{{ grafana_dir }}"
register: compose_ps_final
changed_when: false
Expand Down
8 changes: 4 additions & 4 deletions automation/test-execution/dashboard-examples/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@ This Streamlit dashboard provides comprehensive analysis of vLLM benchmark resul
**Server-Side Metrics (vLLM)**
- Internal server state
- Queue depth, cache usage, token generation rates
- Source: `vllm-metrics.json` (collected via Prometheus)
- Source: `vllm-metrics.json` (scraped directly from `/metrics` endpoint)

**Architecture:**
```
Benchmark Run
↓
GuideLLM → benchmarks.json (client metrics)
↓
vLLM Server → Prometheus → vllm-metrics.json (server metrics)
vLLM Server /metrics → vllm-metrics.json (server metrics)
↓
Streamlit Dashboard → Analysis + Visualization
```
Expand Down Expand Up @@ -197,7 +197,7 @@ ansible-playbook start-grafana.yml
results/llm/model-name/test-date/config/
├── benchmarks.json # GuideLLM results (client-side)
├── test-metadata.json # Test configuration
├── vllm-metrics.json # vLLM server metrics (from Prometheus)
├── vllm-metrics.json # vLLM server metrics (scraped from /metrics)
└── vllm-server.log # Server logs
```

Expand Down Expand Up @@ -246,7 +246,7 @@ results/llm/
└── vllm-server.log ← Server logs
```

**Default path:** `../../../../../results/llm` (relative to dashboard pages)
**Default path:** `../../../../results/llm` (relative to dashboard pages)

## Configuration

Expand Down
2 changes: 1 addition & 1 deletion automation/test-execution/dashboard-examples/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Safe to run multiple times

SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
cd "$SCRIPT_DIR"
cd "$SCRIPT_DIR" || { echo "Error: Cannot change to script directory"; exit 1; }

echo "Setting up Python virtual environment for dashboards..."
echo ""
Expand Down
4 changes: 2 additions & 2 deletions automation/test-execution/dashboard-examples/vllm_dashboard/pages/2_🖥️_Server_Metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,8 +286,8 @@ def mean_metric(sample: Dict, metric_name: str) -> float:
itl_sum = sum_metric(s, 'vllm:request_time_per_output_token_seconds_sum')
itl_count = sum_metric(s, 'vllm:request_time_per_output_token_seconds_count')
if i > 0 and itl_count > 0:
prev_sum = sum_metric(samples[i-1], 'vllm:time_per_output_token_seconds_sum')
prev_count = sum_metric(samples[i-1], 'vllm:time_per_output_token_seconds_count')
prev_sum = sum_metric(samples[i-1], 'vllm:request_time_per_output_token_seconds_sum')
prev_count = sum_metric(samples[i-1], 'vllm:request_time_per_output_token_seconds_count')
delta_sum = itl_sum - prev_sum
delta_count = itl_count - prev_count
itl_latency.append((delta_sum / delta_count * 1000) if delta_count > 0 else 0) # Convert to ms
Expand Down
7 changes: 6 additions & 1 deletion automation/test-execution/grafana/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,9 @@ scrape_configs:
- job_name: 'vllm-live'
scrape_interval: 10s
static_configs:
- targets: ['host.containers.internal:8000']
# macOS: use host.containers.internal:8000
# Linux: use localhost:8000
- targets: ['<vllm_host>:8000']
metric_relabel_configs:
- source_labels: [__name__]
regex: 'vllm_.*'
Expand All @@ -336,6 +338,9 @@ scrape_configs:
- **Scrape interval:** 10s for real-time monitoring
- **Retention:** 30 days by default
- **Storage:** Local volume (persists between restarts)
- **Target host:** Platform-specific
- macOS: Use `host.containers.internal:8000` (bridge networking)
- Linux: Use `localhost:8000` (host networking)

### Customization

Expand Down
6 changes: 3 additions & 3 deletions automation/test-execution/grafana/dashboards/vllm_comprehensive.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,7 +1247,7 @@
{
"datasource": {
"type": "prometheus",
"uid": "edx8memhpd9tsa"
"uid": "prometheus-vllm"
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Avoid hardcoded datasource UIDs in a variable-driven dashboard.

These hardcoded entries bypass ${DS_PROMETHEUS} and create inconsistent behavior (notably in panel id 15, where Line 1366 still uses ${DS_PROMETHEUS}). Keep all targets bound to the same template variable.

🔧 Proposed fix 
-            "uid": "prometheus-vllm"
+            "uid": "${DS_PROMETHEUS}"

(Apply at Lines 1250, 1350, and 1463.)

As per coding guidelines, "Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity."

Also applies to: 1350-1350, 1463-1463

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@automation/test-execution/grafana/dashboards/vllm_comprehensive.json` at line
1250, Replace hardcoded datasource UIDs ("prometheus-vllm") in the dashboard
JSON with the template variable ${DS_PROMETHEUS} so all panels use the same
datasource variable; locate occurrences of "uid": "prometheus-vllm" and change
them to reference ${DS_PROMETHEUS}, and verify panel id 15 (the panel that still
uses the hardcoded UID) and any other targets use ${DS_PROMETHEUS} in their
target.datasource or datasource fields to ensure consistent, variable-driven
datasource binding.

},
"disableTextWrap": false,
"editorMode": "code",
Expand Down Expand Up @@ -1347,7 +1347,7 @@
{
"datasource": {
"type": "prometheus",
"uid": "edx8memhpd9tsa"
"uid": "prometheus-vllm"
},
"disableTextWrap": false,
"editorMode": "code",
Expand Down Expand Up @@ -1460,7 +1460,7 @@
{
"datasource": {
"type": "prometheus",
"uid": "edx8memhpd9tsa"
"uid": "prometheus-vllm"
},
"disableTextWrap": false,
"editorMode": "code",
Expand Down
Loading
Loading