Skip to content

Remove duplicate and unused variant of git-logo.svg #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove duplicate and unused variant of git-logo.svg #89

wants to merge 1 commit into from

Conversation

@maxwiederhold
Copy link

@maxwiederhold maxwiederhold commented Jun 26, 2019

This removes the duplicate image file git-Logo.svg, which is unused across the project.
It causes issues when used in case-insensitive operating systems.

ASzc added a commit to ASzc/keycloak that referenced this pull request Feb 10, 2020
@ASzc
KEYCLOAK-9436 Filter out git-Logo.svg to fix zip for Windows
4361354 
Should be safe to filter, upstream PR redhat-rcue/rcue#89 will remove
eventually, and tests use lowercase version of this file.
@ASzc ASzc mentioned this pull request Feb 10, 2020
Merged
stianst pushed a commit to keycloak/keycloak that referenced this pull request Feb 11, 2020
@ASzc @stianst
KEYCLOAK-9436 Filter out git-Logo.svg to fix zip for Windows
3ef338d 
Should be safe to filter, upstream PR redhat-rcue/rcue#89 will remove
eventually, and tests use lowercase version of this file.
@nngo
Copy link

nngo commented Apr 23, 2020

This issue also manifest itself doing a git clone of this repo under Windows.

$ git clone [email protected]:redhat-rcue/rcue.git
Cloning into 'rcue'...
remote: Enumerating objects: 4, done.
remote: Counting objects: 100% (4/4), done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 7632 (delta 0), reused 0 (delta 0), pack-reused 7628
Receiving objects: 100% (7632/7632), 19.82 MiB | 1.85 MiB/s, done.
Resolving deltas: 100% (5056/5056), done.
warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'dist/img/git-Logo.svg'
  'dist/img/git-logo.svg'

Can we kick off the CI build again and get this fixed?

@nngo nngo mentioned this pull request Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxwiederhold @nngo