-
Notifications
You must be signed in to change notification settings - Fork 30
updates hybrid search notebook to use HybridQuery and TextQuery #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but tests are failing for some reason
@@ -32,7 +32,7 @@ | |||
"metadata": {}, | |||
"outputs": [], | |||
"source": [ | |||
"%pip install -q \"redisvl>=0.4.1\" sentence-transformers pandas \"redis>=5.2.0\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justin-cechmanek @rbs333 the test is failing because this version of redisvl
doesn't exist. Our logs must cover up the root of the issue because we use -q
for force it quite mode. So you can use the git+https style pip install here to pass the test, wait until 0.5.0
is on pypi, and then update. Also, for safety, let's do a pin on 0.5.0 instead of >=
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I fixed the imports based on latest redisvl
bump to 0.5.1
and fixed a few small formatting things. Merging even though the test is failing as I think this is still due to the hugging face rate limiting issues we've been facing.
To showcase how to do hybrid search after RedisVL 0.5.0 is released.