Print more stats; print WS_SEARCH as ef #29
Conversation
|
Accepted pull request to modify WS_SEARCH to SEARCH_WINDOW_SIZE. Should we still use WS_SEARCH? |
There was a problem hiding this comment.
Pull Request Overview
This PR adds more detailed logging output to the experiment runner to improve visibility into experiment progress. The changes primarily focus on displaying memory usage statistics during uploads and search performance metrics during query execution.
- Adds memory usage and vector index size logging during data upload
- Prints search precision and RPS (requests per second) statistics during query execution
- Updates the
efparameter extraction to check forWS_SEARCHas a fallback whenefis not found
| print(f"{used_memory=}") | ||
| if (index_info := memory_usage.get("index_info")) is not None: | ||
| if (vector_index_sz_mb := index_info.get("vector_index_sz_mb")) is not None: | ||
| print(f"{vector_index_sz_mb=}") |
There was a problem hiding this comment.
The walrus operator assignment in the condition will fail if memory_usage is None or not a dictionary. Add a null check for memory_usage before calling .get() method.
| print(f"{vector_index_sz_mb=}") | |
| if isinstance(memory_usage, dict): | |
| if (used_memory := memory_usage.get("used_memory")) is not None: | |
| print(f"{used_memory=}") | |
| if (index_info := memory_usage.get("index_info")) is not None: | |
| if (vector_index_sz_mb := index_info.get("vector_index_sz_mb")) is not None: | |
| print(f"{vector_index_sz_mb=}") |
Copilot uses AI. Check for mistakes.
| print(f"{used_memory=}") | ||
| if (index_info := memory_usage.get("index_info")) is not None: | ||
| if (vector_index_sz_mb := index_info.get("vector_index_sz_mb")) is not None: | ||
| print(f"{vector_index_sz_mb=}") |
There was a problem hiding this comment.
This code assumes memory_usage is a dictionary, but it could be None or a different type. The same null check issue applies here as with the used_memory access above.
| print(f"{vector_index_sz_mb=}") | |
| if isinstance(memory_usage, dict): | |
| if (used_memory := memory_usage.get("used_memory")) is not None: | |
| print(f"{used_memory=}") | |
| if (index_info := memory_usage.get("index_info")) is not None: | |
| if (vector_index_sz_mb := index_info.get("vector_index_sz_mb")) is not None: | |
| print(f"{vector_index_sz_mb=}") |
Copilot uses AI. Check for mistakes.
| @@ -186,6 +194,7 @@ def run_experiment( | |||
| f"Calibrated {top=} {precision=} {calibration_value=} {calibration_precision=!s}" | |||
| ) | |||
| searcher.search_params["search_params"][calibration_param] = calibration_value | |||
| ef = calibration_value | |||
There was a problem hiding this comment.
The ef variable is being overwritten with calibration_value but this assignment appears to serve no purpose since ef is only used for printing in the loop and this assignment happens after the print statement. This could be a logic error.
| ef = calibration_value |
Copilot uses AI. Check for mistakes.
This makes it easier to see how the experiments are progressing.