Skip to content

RI-6570 Verify delete operations for all key types in the browsers module #4729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025

Conversation

valkirilov
Copy link
Collaborator

@valkirilov valkirilov commented Jul 18, 2025

Description

Add new E2E tests to check the delete functionalities for different key types in the Browsers module. These tests make sure that you can delete an existing key - both from the list and its details page.

image

How the tests work

  • First, prepare the data for the test using the Redis API (it's easier and faster and also, the UI flow for creating keys is already covered in another test suite)
  • Then we open the Details Panel by clicking on the key we just added (in the table in the UI)
  • Then, we click on the delete icon button and verify whether the record is deleted successfully

Note: Once PR: 4723 is merged, make sure to update the target branch of this pull request to lead to feature/RI-6570/PlayWright branch.

Code Changes

  • Extend browser page locators to provide helpers for dealing with the state of the keys and their values in details drawer
  • Add e2e tests to verify that you can delete all various key types

How to run the tests

You can always refer to the README, but simply running the following command should do the trick for you

# From the root directory
yarn dev:api

# In a new tab, again from the root directory
yarn dev:ui

# In a new tab, but this time go to tests/playwright directory
yarn test:chromium:local-web browser/keys-delete 

# The, check the detailed report an all the video recordings
yarn playwright show-report

Delete Keys

yarn test:chromium:local-web browser/keys-delete 
Screenshot 2025-07-16 at 14 08 05

Copy link
Contributor

github-actions bot commented Jul 18, 2025

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 81.37% 18402/22616
🟡 Branches 67% 8068/12042
🟡 Functions 75.13% 4866/6477
🟢 Lines 81.75% 18005/22024

Test suite run success

4792 tests passing in 628 suites.

Report generated by 🧪jest coverage report action from d76c948

@valkirilov valkirilov self-assigned this Jul 18, 2025
@pawelangelow pawelangelow deleted the feature/RI-6570/e2e-playwright-browser-keys-delete branch July 22, 2025 14:19
@pawelangelow pawelangelow restored the feature/RI-6570/e2e-playwright-browser-keys-delete branch July 22, 2025 14:22
@pawelangelow pawelangelow reopened this Jul 22, 2025
Copy link
Contributor

Code Coverage - Backend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 92.34% 13787/14931
🟡 Branches 74% 4147/5604
🟢 Functions 85.82% 2124/2475
🟢 Lines 92.13% 13180/14306

Test suite run success

2941 tests passing in 286 suites.

Report generated by 🧪jest coverage report action from d76c948

@valkirilov valkirilov force-pushed the feature/RI-6570/e2e-playwright-browser-keys-read branch from 76052ac to bc2fd09 Compare July 25, 2025 08:14
Base automatically changed from feature/RI-6570/e2e-playwright-browser-keys-read to main July 25, 2025 08:39
* added e2e test to verify whether the delete functionality is working fine for all key types listed in the browser module

re #RI-6570
@valkirilov valkirilov force-pushed the feature/RI-6570/e2e-playwright-browser-keys-delete branch from d76c948 to 9bd12bf Compare July 25, 2025 08:55
@valkirilov valkirilov merged commit 1d8e24e into main Jul 25, 2025
4 checks passed
@valkirilov valkirilov deleted the feature/RI-6570/e2e-playwright-browser-keys-delete branch July 25, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants