Fix e2e tests trigger #4850
Open
Fix e2e tests trigger #4850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage - Integration Tests
|
Code Coverage - Frontend unit tests
Test suite run success5048 tests passing in 663 suites. Report generated by 🧪jest coverage report action from 12f2a87 |
Code Coverage - Backend unit tests
Test suite run success2950 tests passing in 286 suites. Report generated by 🧪jest coverage report action from 12f2a87 |
pawelangelow
previously approved these changes
Aug 13, 2025
pawelangelow
previously approved these changes
Aug 13, 2025
pd-redis
previously approved these changes
Aug 13, 2025
pd-redis
previously approved these changes
Aug 13, 2025
KrumTy
commented
Aug 13, 2025
Comment on lines
+50
to
+51
| builds-complete: | ||
| needs: [build-docker, build-appimage] |
There was a problem hiding this comment.
intermediate job to wait for both builds to complete (~5mins) to avoid running tests when the other build has failed and the whole workflow will be marked as failed in the end anyway
KIvanow
previously approved these changes
Aug 13, 2025
KrumTy
requested review from
dantovska,
ArtemHoruzhenko and
valkirilov
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when a PR is approved for the first time, it is labeled as e2e-approved. And when a e2e-approved label is added, it should trigger e2e tests.
In reality what happens is when a PR is approved, the e2e-approved label is added, but the workflow for tests does not trigger. However if the PR is labeled manually via Github ui as e2e-approved, the tests do trigger.
Potential solution could be adding github secret to the label action to mimic authorized labelingSolution summary
This PR reworks how E2E tests are triggered:
E2E tests run only after a PR is approved (or when manually dispatched), per on commit sha