RI-7295: Fix Search screen buttons alignment #4851
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelangelow
requested review from
KrumTy,
dantovska,
ArtemHoruzhenko,
pd-redis,
KIvanow and
valkirilov
as code owners
dantovska
previously approved these changes
Aug 13, 2025
pd-redis
reviewed
Aug 13, 2025
| @@ -9,5 +9,6 @@ export const StyledHeaderAction = styled(FlexGroup)` | |||
| ` | |||
|
|
|||
| export const StyledWrapper = styled(FlexGroup)` | |||
| align-items: center; | |||
There was a problem hiding this comment.
You don't need this, FlexGroup has property align, that does the same thing.
Also, it seems at least to me, that Row component is better suited for this use case.
pd-redis
requested changes
Aug 13, 2025
There was a problem hiding this comment.
This entire thing is redundant, remove it!
pawelangelow
force-pushed
the
fe/RI-7295/fix-search-screen-look-and-feel
branch
from
e204d32 to
54922c1
Compare
Code Coverage - Frontend unit tests
Test suite run success5048 tests passing in 663 suites. Report generated by 🧪jest coverage report action from 2f67a59 |
KrumTy
previously approved these changes
Aug 14, 2025
pd-redis
reviewed
Aug 14, 2025
| /> | ||
| </StyledWrapper> | ||
| <> | ||
| <FlexGroup align="center"> |
There was a problem hiding this comment.
Suggested change
| <FlexGroup align="center"> | |
| <Row align="center"> |
| open={isManageIndexesDrawerOpen} | ||
| onOpenChange={setIsManageIndexesDrawerOpen} | ||
| /> | ||
| </FlexGroup> |
There was a problem hiding this comment.
Suggested change
| </FlexGroup> | |
| </Row> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After