Skip to content

RI-6927: Rename some provider and telemetry event names #4855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dantovska
Copy link
Collaborator

@dantovska dantovska commented Aug 13, 2025

Renaming telemetry events and providers, to match the new names for Redis Cloud and Redis Cluster.

  • rename telemetry events
  • rename providers
  • create migration script to update the provider property for already existing instances

Telemetry events:

RE_CLUSTER -> REDIS_SOFTWARE applied to:

  • CONFIG_DATABASES_RE_CLUSTER_AUTODISCOVERY_SUBMITTED
  • CONFIG_DATABASES_RE_CLUSTER_AUTODISCOVERY_SUCCEEDED
  • CONFIG_DATABASES_RE_CLUSTER_AUTODISCOVERY_FAILED
  • CONFIG_DATABASES_RE_CLUSTER_AUTODISCOVERY_CANCELLED

RE_CLOUD -> REDIS_CLOUD applied to:

  • CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_SUBMITTED
  • CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_SUBSCRIPTIONS_SUCCEEDED
  • CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_SUBSCRIPTIONS_FAILED
  • CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_DATABASES_SUCCEEDED
  • CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_DATABASES_FAILED
  • CONFIG_DATABASES_RE_CLOUD_AUTODISCOVERY_CANCELLED

Providers:

  • RE_CLOUD -> REDIS_CLOUD
  • RE_CLUSTER -> REDIS_SOFTWARE
  • REDIS_ENTEPRISE -> OTHER_REDIS_MANAGED

Refactoring other methods/variables/constants for concistency:

  • RE_CLOUD to REDIS_CLOUD
  • RE_CLUSTER to REDIS_SOFTWARE
  • ignored the REDIS_ENTEPRISE to OTHER_REDIS_MANAGED - did not make sense as a name. For Example RedisEnterpriseDto -> OtherRedisManagedDto doesn't make sense to me.

@dantovska dantovska self-assigned this Aug 13, 2025
Copy link
Contributor

github-actions bot commented Aug 13, 2025

Code Coverage - Integration Tests

Status Category Percentage Covered / Total
🟢 Statements 81.56% 16199/19861
🟡 Branches 64.39% 7276/11299
🟡 Functions 70.34% 2268/3224
🟢 Lines 81.19% 15237/18766

Copy link
Contributor

github-actions bot commented Aug 13, 2025

Code Coverage - Backend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 92.34% 13816/14962
🟡 Branches 74.02% 4163/5624
🟢 Functions 85.84% 2127/2478
🟢 Lines 92.14% 13205/14332

Test suite run success

2942 tests passing in 286 suites.

Report generated by 🧪jest coverage report action from 77a1114

Copy link
Contributor

github-actions bot commented Aug 13, 2025

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 81.47% 19045/23376
🟡 Branches 66.87% 8326/12451
🟡 Functions 75.28% 4985/6622
🟢 Lines 81.88% 18642/22767

Test suite run success

4879 tests passing in 635 suites.

Report generated by 🧪jest coverage report action from 77a1114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant