RI-7365: Show no indexes message #4870
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelangelow
requested review from
KrumTy,
dantovska,
ArtemHoruzhenko,
pd-redis,
KIvanow and
valkirilov
as code owners
Code Coverage - Frontend unit tests
Test suite run success5061 tests passing in 665 suites. Report generated by 🧪jest coverage report action from 134aff8 |
KrumTy
reviewed
Aug 15, 2025
|
|
||
| return ( | ||
| <StyledManageIndexesListAction data-testid="manage-indexes-list"> | ||
| {loading && <Loader data-testid="manage-indexes-list--loader" />} | ||
|
|
||
| {!loading && !hasIndexes && <NoIndexesMessage />} |
There was a problem hiding this comment.
maybe worth adding a test for the empty list
| import { CallOut } from 'uiSrc/components/base/display/call-out/CallOut' | ||
| import { Pages } from 'uiSrc/constants' | ||
| import useStartWizard from '../hooks/useStartWizard' |
There was a problem hiding this comment.
you can probably simplify this component's tests by mocking '../hooks/useStartWizard' as opposed to it's internals ('react-router-dom') since you've already tested them; not mandatory ofc
Comment on lines
+13
to
+15
| return { | ||
| start, | ||
| } |
There was a problem hiding this comment.
if there's no plan on adding more attributes to the return object, it might be better to return just the function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no indexes
When there are indexes