-
Notifications
You must be signed in to change notification settings - Fork 399
RI-7275 Create e2e tests for "Vector Search" page #4921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code Coverage - Integration Tests
|
Code Coverage - Backend unit tests
Test suite run success2951 tests passing in 286 suites. Report generated by 🧪jest coverage report action from aaf3540 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR creates comprehensive e2e tests for the Vector Search page to verify its availability and fallback behavior under different Redis configurations. The tests validate that the page opens correctly when requirements are met, shows appropriate fallback messages when the Redis Query Engine module is disabled, and displays version compatibility warnings when Redis doesn't support Vector Sets.
- Implements comprehensive e2e test suite for Vector Search page functionality
- Adds page object models for Vector Search and Create Index pages with proper selectors
- Refactors utility functions to support multiple database configurations
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
tests/playwright/types/databases.ts | Makes host/port optional and adds new optional parameters for enhanced database configuration flexibility |
tests/playwright/tests/vector-search/version-compatibility.spec.ts | Implements three test cases covering Vector Search page accessibility and fallback scenarios |
tests/playwright/pageObjects/pages/vector-search/vector-search-page.ts | Creates page object model with selectors and navigation methods for Vector Search functionality |
tests/playwright/pageObjects/pages/vector-search/create-index-page.ts | Adds page object for Create Index page with verification methods |
tests/playwright/helpers/utils.ts | Updates utility functions to accept configurable database parameters instead of hardcoded values |
tests/playwright/helpers/conf.ts | Adds type annotations to all database configuration objects for better type safety |
redisinsight/ui/src/pages/vector-search/pages/VectorSearchPage.tsx | Adds test IDs to enable proper test automation targeting |
redisinsight/ui/src/pages/vector-search/create-index/steps/*.tsx | Adds test IDs to various UI components for test automation support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tests/playwright/pageObjects/pages/vector-search/vector-search-page.ts
Outdated
Show resolved
Hide resolved
tests/playwright/tests/vector-search/version-compatibility.spec.ts
Outdated
Show resolved
Hide resolved
tests/playwright/tests/vector-search/version-compatibility.spec.ts
Outdated
Show resolved
Hide resolved
tests/playwright/tests/vector-search/version-compatibility.spec.ts
Outdated
Show resolved
Hide resolved
Code Coverage - Frontend unit tests
Test suite run success5113 tests passing in 673 suites. Report generated by 🧪jest coverage report action from aaf3540 |
2a4df5b
to
1eb268a
Compare
- it should open the page when all reqreumenets are met - it should open fallback message when redis quirey engine modue is not enabled - it should show fallback message when redis version doens't support vector sets re #RI-7275
1eb268a
to
aaf3540
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Created e2e tests to verify the availability of the "Vector Search" page:
How the tests work
How to run the tests
You can always refer to the README, but simply running the following commands should do the trick for you