fix test runner #5069
fix test runner #5069
Conversation
pd-redis
requested review from
ArtemHoruzhenko,
KrumTy,
dantovska,
pawelangelow and
valkirilov
as code owners
| const handlers: HttpHandler[] = [ | ||
| // useGetClusterDetailsQuery | ||
| rest.get<DatabaseInstanceResponse[]>( | ||
| http.get<any, DatabaseInstanceResponse[]>( |
There was a problem hiding this comment.
Looking at the http.get call, I'm a bit confused about the generic types. From what I understand about MSW's type signature, the generics are <PathParams, ResponseBodyType, RequestBodyType>. So:
-
Path params (
any)
Since we're not using any path parameters in this URL pattern, could we useRecord<string, never>or just omit it instead ofany? -
Response body type (
DatabaseInstanceResponse[])
We're actually returningCLUSTER_DETAILS_DATA_MOCKwhich is typed asClusterDetails(a single object, not an array). Shouldn't this be:http.get<Record<string, never>, ClusterDetails>(...)
Or the ClusterDetails interface is actually a subset of DatabaseInstanceResponse, and it's fine.
- General question
When I remove these type parameters entirely, I don't see any TypeScript errors. Are these types actually being validated somewhere, or are they more for documentation purposes? Maybe I'm missing some context about how MSW uses these in the testing setup?
I'm just trying to make sure I understand the pattern correctly.
There was a problem hiding this comment.
since this is purely test code, and TS types have no effect on actual results, I am in favor of omitting them overall
* RI-7676: fix msw unhandled requests causing libuv error
…Popover.spec.tsx, TemplateForm.spec.tsx
* Properly msw server to return success response for unhandled requests temporary Fix store issue in RediSearchIndexesList.spec.tsx * fix the rest tests related to store initialization issue
Code Coverage - Frontend unit tests
Test suite run success5162 tests passing in 677 suites. Report generated by 🧪jest coverage report action from 59098ed |
This pull request focuses on updating the MSW (Mock Service Worker) API usage throughout the codebase. It also upgrades related dependencies and adjusts the Jest configuration to support these changes.
MSW API Modernization and Type Cleanup:
update MSW version
updated calls to follow current API of MSW
Dependency and Jest Configuration Updates:
Upgraded
mswto version^2.11.5and addedjest-fixed-jsdomChanged Jest configuration to use
jest-fixed-jsdomas the test environment, addeduntil-asyncto thetransformIgnorePatterns, and includedcustomExportConditionsintestEnvironmentOptions. All of this is to support MSW 2 with jestdomCode Cleanup:
FormFieldinFormField.ts.