Skip to content

RI-7637 Loading indicator for tables in Browser keys details #5104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
Merged

RI-7637 Loading indicator for tables in Browser keys details #5104

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5575d56
fix(ui): bring back loading indicator for table sin browsers keys det…
valkirilov Oct 23, 2025
17fac76
refactor(ui): rename property
valkirilov Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion redisinsight/ui/src/components/base/display/progress-bar/progress-bar-loader.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,13 @@ interface LoaderContainerProps {
children?: ReactNode
style?: React.CSSProperties
className?: string
isAbsolutePositioned?: boolean
Copy link
Collaborator

@pd-redis pd-redis Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this name

Copy link
Collaborator

@pd-redis pd-redis Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just absolute?!

Copy link
Member Author

@valkirilov valkirilov Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, simplified.

}

export const LoaderContainer = styled.div<LoaderContainerProps>`
position: relative;
position: ${({ isAbsolutePositioned }) =>
isAbsolutePositioned ? 'absolute' : 'relative'};
width: 100%;
height: 3px;
overflow: hidden;
border-radius: 2px;
Expand Down
1 change: 1 addition & 0 deletions redisinsight/ui/src/components/virtual-table/VirtualTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,7 @@ const VirtualTable = (props: IProps) => {
{loading && !hideProgress && (
<ProgressBarLoader
color="primary"
isAbsolutePositioned
data-testid="progress-key-table"
/>
)}
Expand Down
8 changes: 3 additions & 5 deletions ...owser/modules/key-details/components/hash-details/hash-details-table/HashDetailsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,8 @@
)

return (
<Text color="secondary"
<Text
color="secondary"
style={{ maxWidth: '100%', whiteSpace: 'break-spaces' }}
component="div"
>
Expand Down Expand Up @@ -528,9 +529,7 @@
testid={`remove-hash-button-${field}`}
handleDeleteItem={handleDeleteField}
handleButtonClick={handleRemoveIconClick}
appendInfo={
length === 1 ? HelpTexts.REMOVE_LAST_ELEMENT() : null
}
appendInfo={length === 1 ? HelpTexts.REMOVE_LAST_ELEMENT() : null}

Check warning on line 532 in redisinsight/ui/src/pages/browser/modules/key-details/components/hash-details/hash-details-table/HashDetailsTable.tsx

View workflow job for this annotation

GitHub Actions / Coverage annotations (🧪 jest-coverage-report-action)

🌿 Branch is not covered 

Warning! Not covered branch
/>
</StopPropagation>
)
Expand Down Expand Up @@ -607,7 +606,6 @@
)}
>
<VirtualTable
hideProgress
expandable
autoHeight
tableRef={tableRef}
Expand Down
1 change: 0 additions & 1 deletion ...owser/modules/key-details/components/list-details/list-details-table/ListDetailsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,6 @@ const ListDetailsTable = () => {
>
<VirtualTable
autoHeight
hideProgress
expandable
tableRef={tableRef}
selectable={false}
Expand Down
5 changes: 1 addition & 4 deletions .../browser/modules/key-details/components/set-details/set-details-table/SetDetailsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,9 +290,7 @@
handleDeleteItem={handleDeleteMember}
handleButtonClick={handleRemoveIconClick}
testid={`set-remove-btn-${member}`}
appendInfo={
length === 1 ? HelpTexts.REMOVE_LAST_ELEMENT() : null
}
appendInfo={length === 1 ? HelpTexts.REMOVE_LAST_ELEMENT() : null}

Check warning on line 293 in redisinsight/ui/src/pages/browser/modules/key-details/components/set-details/set-details-table/SetDetailsTable.tsx

View workflow job for this annotation

GitHub Actions / Coverage annotations (🧪 jest-coverage-report-action)

🌿 Branch is not covered 

Warning! Not covered branch
/>
</div>
)
Expand Down Expand Up @@ -324,7 +322,6 @@
>
<VirtualTable
autoHeight
hideProgress
expandable
selectable={false}
keyName={key}
Expand Down
1 change: 0 additions & 1 deletion ...owser/modules/key-details/components/zset-details/zset-details-table/ZSetDetailsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,6 @@ const ZSetDetailsTable = (props: Props) => {
<VirtualTable
autoHeight
tableRef={tableRef}
hideProgress
expandable
keyName={key}
headerHeight={headerHeight}
Expand Down
Loading