Skip to content

RI-8276 i18n: migrate Cluster Details analytics page#6198

Merged
valkirilov merged 1 commit into
mainfrom
fe/feature/RI-8276/i18n-analytics-cluster-details
Jul 14, 2026
Merged

RI-8276 i18n: migrate Cluster Details analytics page#6198
valkirilov merged 1 commit into
mainfrom
fe/feature/RI-8276/i18n-analytics-cluster-details

Conversation

@valkirilov

@valkirilov valkirilov commented Jul 13, 2026

Copy link
Copy Markdown
Member

Routes the Cluster Details analytics page through i18next under analytics.clusterDetails.* (+ shared analytics.units.*), with Bulgarian translations. Text-only; no behavior change.


Note

Low Risk
Text-only localization on an analytics page; test IDs were adjusted to use stable IDs instead of translated labels.

Overview
Internationalizes the Cluster Details analytics screen by replacing hardcoded English strings with i18next keys under analytics.clusterDetails.* and shared analytics.units.*, including Bulgarian entries in bg.json.

The page title, header metric labels, donut chart titles, table column headers (with pluralized primary-node count), empty state copy, and unit suffixes (kb/s, B, %) now resolve through useTranslation or the i18n singleton in table constants/formatters. ClusterDetailsHeader adds stable metric id values for React keys and data-testids so they stay English regardless of locale; uptime’s " s" suffix in the tooltip remains literal per an inline comment.

Reviewed by Cursor Bugbot for commit 50cfecc. Bugbot is set up for automated code reviews on this repo. Configure here.

@valkirilov valkirilov requested a review from a team as a code owner July 13, 2026 12:24

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 39096b4dd3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Route the Cluster Details page through i18n under analytics.clusterDetails.*
with Bulgarian translations: page title, node table headers (primary-nodes
count via i18next plurals) + empty state, donut chart titles, and header
metrics. Column headers resolve at render via i18n.t() functions in the
config; a stable `id` on each header metric keeps React keys/test ids
independent of the translated label.

Extends the shared analytics.units.* group (B/kb/s/%/s) resolved through
t() so those units localize to Bulgarian.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@valkirilov valkirilov force-pushed the fe/feature/RI-8276/i18n-analytics-cluster-details branch from 39096b4 to 50cfecc Compare July 13, 2026 12:37
@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 83.89% 27211/32435
🟡 Branches 69.69% 11580/16616
🟡 Functions 79.28% 7291/9196
🟢 Lines 84.37% 26501/31411

Test suite run success

7763 tests passing in 860 suites.

Report generated by 🧪jest coverage report action from 50cfecc

@valkirilov valkirilov merged commit 4a791f1 into main Jul 14, 2026
21 checks passed
@valkirilov valkirilov deleted the fe/feature/RI-8276/i18n-analytics-cluster-details branch July 14, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants