Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve cluster connection pool logic when disconnecting #1864

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

fix: Improve cluster connection pool logic when disconnecting #1864

wants to merge 21 commits into from

Commits on Mar 6, 2024

  1. Tell Redis cluster to disable protected mode before running tests

    @martinslota
    martinslota committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    0d2a416 View commit details
    Browse the repository at this point in the history

  2. Try to enable Redis cluster tests on CI

    @martinslota
    martinslota committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    5385c8e View commit details
    Browse the repository at this point in the history

  3. Add a failing test around Redis cluster disconnection logic

    @martinslota
    martinslota committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    f67d73a View commit details
    Browse the repository at this point in the history

  4. Rename function parameter

    @martinslota
    martinslota committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    66efb1a View commit details
    Browse the repository at this point in the history

  5. Turn node error listener into an arrow function so that this points… 

    … to the connection pool instance
    @martinslota
    martinslota committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    f0cadc5 View commit details
    Browse the repository at this point in the history

  6. Extract node listeners into separate constants

    @martinslota
    martinslota committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    49e9edd View commit details
    Browse the repository at this point in the history

  7. Keep track of listeners along with each Redis client

    @martinslota
    martinslota committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    dee2623 View commit details
    Browse the repository at this point in the history

  8. Remove node listeners when the node is being removed

    @martinslota
    martinslota committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    4d519a6 View commit details
    Browse the repository at this point in the history

  9. Emit node removal events whenever a node is removed

    @martinslota
    martinslota committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    ed3e190 View commit details
    Browse the repository at this point in the history

  10. When resetting, add nodes before removing old ones

    @martinslota
    martinslota committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    cd3b74a View commit details
    Browse the repository at this point in the history

  11. Rename Node type to NodeRecord for clarity

    @martinslota
    martinslota committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    2b47e94 View commit details
    Browse the repository at this point in the history

  12. Also rename the field holding node records

    @martinslota
    martinslota committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    e835185 View commit details
    Browse the repository at this point in the history

  13. Rename variable to nodeRecord

    @martinslota
    martinslota committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    eb2d07c View commit details
    Browse the repository at this point in the history

  14. Rename another variable to nodeRecord

    @martinslota
    martinslota committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    62427a8 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Fix a reference to connection pool nodes

    @martinslota
    martinslota committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    2979176 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Do not fail when retrieving a node by non-existing key

    @martinslota
    martinslota committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    4d4ba69 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Merge branch 'main' into martinslota/clean-up-node-listeners-upon-dis… 

    …connect
    @martinslota
    martinslota authored Jun 10, 2024
    Configuration menu
    Copy the full SHA
    1c3df53 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Revert "Fix a reference to connection pool nodes" 

    This reverts commit 2979176.
    @martinslota
    martinslota committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    5a490c1 View commit details
    Browse the repository at this point in the history

  2. Fix a reference to connection pool nodes, this time a bit more correctly

    @martinslota
    martinslota committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    d67b1b6 View commit details
    Browse the repository at this point in the history

  3. Add a valid slots table to mock server in tests that expect to be abl… 

    …e to connect using the Cluster client
    @martinslota
    martinslota committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    d779cb4 View commit details
    Browse the repository at this point in the history

  4. Do not assume that node removal will occur *after* refreshSlotsCache(… 

    …) is finished
    @martinslota
    martinslota committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    3165ff0 View commit details
    Browse the repository at this point in the history