Add configurable retry delay for Sentinel reconnection (#2864) #4379
Conversation
Adds configurable delay strategy for Sentinel subscription retries with exponential backoff and jitter support. Prevents all clients from reconnecting simultaneously when connection is lost. Default: 5000ms constant delay (backward compatible) New: Configurable via RedisSentinelClient.Builder.sentinelReconnectDelay()
Test Results 285 files +2 285 suites +2 11m 36s ⏱️ -15s Results for commit e10808b. ± Comparison against base commit ea238d6. This pull request skips 1212 tests.♻️ This comment has been updated with latest results. |
| private JedisClientConfig sentinelClientConfig = null; | ||
|
|
||
| // delay between re-subscribing to sentinel nodes after a disconnection | ||
| private Delay sentinellReconnectDelay = DEFAULT_RESUBSCRIBE_DELAY; |
There was a problem hiding this comment.
The variable name "sentinellReconnectDelay" contains a typo with double 'l'. It should be "sentinelReconnectDelay" (single 'l') to match the method name "sentinelReconnectDelay" and standard spelling.
| private Delay sentinellReconnectDelay = DEFAULT_RESUBSCRIBE_DELAY; | |
| private Delay sentinelReconnectDelay = DEFAULT_RESUBSCRIBE_DELAY; |
| */ | ||
| public SentinelClientBuilder<C> sentinelReconnectDelay(Delay reconnectDelay) { | ||
| JedisAsserts.notNull(reconnectDelay, "reconnectDelay must not be null"); | ||
| this.sentinellReconnectDelay = reconnectDelay; |
There was a problem hiding this comment.
The variable name "sentinellReconnectDelay" contains a typo with double 'l'. It should be "sentinelReconnectDelay" (single 'l') to match the method name "sentinelReconnectDelay" and standard spelling.
| protected ConnectionProvider createDefaultConnectionProvider() { | ||
| return new SentineledConnectionProvider(this.masterName, this.clientConfig, this.cache, | ||
| this.poolConfig, this.sentinels, this.sentinelClientConfig); | ||
| this.poolConfig, this.sentinels, this.sentinelClientConfig, sentinellReconnectDelay); |
There was a problem hiding this comment.
The variable name "sentinellReconnectDelay" contains a typo with double 'l'. It should be "sentinelReconnectDelay" (single 'l') to match the method name "sentinelReconnectDelay" and standard spelling.
| } | ||
|
|
||
| /** | ||
| * Sets the delay between re-subscribing to sentinel node after a disconnection.* |
There was a problem hiding this comment.
The JavaDoc has an extra asterisk at the end of the sentence. The line should end with a period, not ".*"
| * Sets the delay between re-subscribing to sentinel node after a disconnection.* | |
| * Sets the delay between re-subscribing to sentinel node after a disconnection. |
Adds configurable delay strategy for Sentinel subscription retries with exponential backoff and jitter support. Prevents all clients from reconnecting simultaneously when connection is lost.
Default: 5000ms constant delay (backward compatible)
New: Configurable via RedisSentinelClient.Builder.sentinelReconnectDelay()
Closes #2864