Skip to content

Conversation

The-East-Wind
Copy link
Contributor

@The-East-Wind The-East-Wind commented Jul 2, 2025

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Partially resolves #3328

Changes

  • remove usage of deprecated flushCommands, isOpen, setAutoFlushCommands and close in integration tests and changed to use alternate methods from StatefulRedisConnection and StatefulRedisClusterConnection.
  • remove usage of deprecated isOpen in set client name flow for cluster commands
  • remove some usages of deprecated getStatefulConnection from integration tests
  • remove deprecated flushCommands, isOpen, setAutoFlushCommands and close methods from command APIs

Follow up

  • getStatefulConnection is still being used in > 50 integration tests, this is to be removed before the method can be removed from the command APIs

@tishun
Copy link
Collaborator

tishun commented Jul 2, 2025

Hey @The-East-Wind , which of the tasks in #3328 does this PR address?

@The-East-Wind
Copy link
Contributor Author

@tishun This aims to partially address follow up to https://github.com/redis/lettuce/issues/2028 clean up the connection-related APIs, e.g. BaseRedisCommands. If the approach I've taken is acceptable I'll follow the same and complete it.

@tishun
Copy link
Collaborator

tishun commented Jul 7, 2025

Hey @The-East-Wind ,

yes, I think this is the correct approach. Do you have something specific that you are concerned about?

@The-East-Wind
Copy link
Contributor Author

The-East-Wind commented Jul 7, 2025

@tishun the number of places which required change was high so I wanted to confirm I was following the right approach before make all the changes so that there is no rework. I was specifically concerned about using try-with-resource for closing connections instead of explicitly calling close as throughout the tests explicit close calls were used instead of try-with-resource.

@tishun tishun added this to the 7.0.0.RELEASE milestone Jul 7, 2025
@tishun tishun added the type: breaking Breaking change label Jul 7, 2025
@The-East-Wind The-East-Wind force-pushed the chore/remove-conn-methods-from-cmd-api branch from 907eebd to 6851931 Compare July 8, 2025 17:46
@The-East-Wind The-East-Wind marked this pull request as ready for review July 8, 2025 17:52
@tishun tishun force-pushed the chore/remove-conn-methods-from-cmd-api branch from 6851931 to a303220 Compare August 8, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated options and logic as part of the 7.0 release
2 participants