Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed infinitely recursive health checks #3557

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

excitoon
Copy link
Contributor

@excitoon excitoon commented Mar 12, 2025

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Fixed infinite recursion in health checks (once and for all).

Fixes #2866
Really fixes #2563

@excitoon excitoon force-pushed the fix-eternity-checks branch from d41a87f to 091f880 Compare March 12, 2025 23:21
@excitoon excitoon force-pushed the fix-eternity-checks branch 5 times, most recently from 637c418 to 6fcc890 Compare March 13, 2025 00:43
@excitoon excitoon force-pushed the fix-eternity-checks branch from 6fcc890 to a4b4639 Compare March 13, 2025 00:46
@excitoon
Copy link
Contributor Author

@petyaslavova please review

@petyaslavova
Copy link
Collaborator

@petyaslavova please review

Hi @excitoon thank you for your contribution! We’ll review your change soon.

@excitoon
Copy link
Contributor Author

Hi Petya, how's your weekend going? 🍻

@excitoon
Copy link
Contributor Author

giphy

@petyaslavova
Copy link
Collaborator

@excitoon Tomorrow is the day for this PR review :)

@petyaslavova petyaslavova added the bug Bug label Mar 25, 2025
@petyaslavova
Copy link
Collaborator

The change looks good to me. With it instead of the max recursion depth reached error, an "redis.exceptions.ConnectionError: max number of clients reached" is raised.
@vladvildanov would this change affect the fix you are working on lately?

@vladvildanov
Copy link
Collaborator

@petyaslavova Not really, LGTM

@petyaslavova petyaslavova merged commit 7bfd4c5 into redis:master Mar 26, 2025
37 checks passed
@excitoon
Copy link
Contributor Author

@petyaslavova Thanks alot!

giphy2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
3 participants