-
Notifications
You must be signed in to change notification settings - Fork 57
Feat/raae 1094 add svs vamana implementation #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat/raae 1094 add svs vamana implementation #404
Conversation
Update minimum redis-py version from 6.2.0 to 6.4.0 to enable support for SVS-VAMANA vector indexing algorithm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good! I think let's add a recipe to the user guide and then we can talk more about the migration class in our 1:1
redisvl/utils/migration.py
Outdated
logger = get_logger(__name__) | ||
|
||
|
||
class IndexMigrator: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this as a way of creating backwards compatibility but might recommend we turn this into a recipe vs a class. Since it would be more of a one time thing people would do I'd rather give an easy guide vs supporting a class in the library moving forward.
Nice! I think we should talk about migrations, but agree that in this case, for migrating a specific aspect of an index rather than more general schema migrations support, or data migrations, a recipe may be best. |
Adds first-class SVS-VAMANA support to redis-vl-python, including compression options, schema validation, Redis capability checks, docs, and tests.
Highlights
Requirements
Compatibility
Docs & Tests