Repository navigation
fix: continue LRU eviction after removals - #1020
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1019
Note
Low Risk
Small, localized fix to client-side LRU bookkeeping in
Update, covered by a new regression test; no auth or persistence impact.Overview
Fixes LRU eviction in
Updatewhen a newly stored value pushesc.sizeoverc.max. The eviction walk from the list front now savesnext := ele.Next()beforeRemove, then continues withele = next, instead of callingNext()on a removed node (which could stop eviction early and leave stale entries).Adds
Cache Evict Multiple Entriesinlru_test.go: a cache sized for two small entries must evict both when a slightly larger third entry is updated in, asserting final size, list length, and that keys0/1are gone while the new key remains.Reviewed by Cursor Bugbot for commit 48a9274. Bugbot is set up for automated code reviews on this repo. Configure here.