[v26.1.x] iceberg: Push Parquest column stats to Iceberg manifests#30777
Open
vbotbuildovich wants to merge 2 commits into
Open
[v26.1.x] iceberg: Push Parquest column stats to Iceberg manifests#30777vbotbuildovich wants to merge 2 commits into
vbotbuildovich wants to merge 2 commits into
Conversation
Thread per-column stats (min/max bounds, null counts, value counts, column sizes) through to the Iceberg data_file manifest entry, where query engines use them for column-level predicate pushdown. Maintain a file-level column_stats_collector in buffered_column_writer that accumulates by merging after each flush_pages(), then use the result after the file is done to get file-level stats. (cherry picked from commit 7f83353)
(cherry picked from commit b4e8232)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #30704
Conflict details
accumulation lines (
file_value_count/file_column_size_bytes) were applied;the incoming bloom-filter block is a separate feature not present on v26.1.x
and was omitted.
stats-truncation feature (
truncate_max/truncate_min,max_stats_truncate_length,is_utf8_string) that does not exist on v26.1.x.Adapted
build_statistics()andflush_page()to the target's non-truncatingbound logic, dropped the redundant
_flushed_stats.record_value()calls infavor of
merge(), added the_file_statscollector, and omitted theunrelated
_bloom_filtermember.per_column_stats(bytes, chunked_vector, serde envelope/rw); omittedbase/format_to.hsince v26.1.x'slocal_file_metadatastill usesoperator<<rather thanformat_to.base_typesdeps(base, bytes, container:chunked_vector, serde, serde:bytes) into the target's
deps list.
//src/v/basedep and the incoming//src/v/bytesdep iniceberg_file_committer's implementation_deps.