make co_return more strict with types#229
Draft
bashtanov wants to merge 2 commits intoredpanda-data:v25.3.xfrom
Draft
make co_return more strict with types#229bashtanov wants to merge 2 commits intoredpanda-data:v25.3.xfrom
bashtanov wants to merge 2 commits intoredpanda-data:v25.3.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, due to a chain of omnivorous templated functions and constructor calls,
co_returnis much more lax with types than plainreturn. In particular,co_returncan implicitly call explicit constructors, which is counter-intuitive.We have seen bugs because of it. They include silent casting of enums such as
raft::errctocluster::errcjust by index. Or strong types such asmodel::offsetandkafka::offsetcast one to another and/or to the underlying type.This change is to avoid it. I understand it should be discussed with Seastar devs, PRing it here to gather internal opinions first.