Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hanging LDES consumer jobs #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elpoelma
Copy link
Collaborator

Created a new PR for this as I apparently cant reopen closed/merged PRs

@elpoelma
Copy link
Collaborator Author

@dkozickis could you take another look at this? It seems that the ping package does not always work as expected.

@dkozickis
Copy link
Contributor

@elpoelma any errors?

@elpoelma
Copy link
Collaborator Author

@elpoelma any errors?

When testing the library seperately, the ping package would always indicate that the endpoint was not alive (even with other endpoints like https://www.google.com/ etc.).

@MPParsley
Copy link
Contributor

Hi,

Would it be an option to implement health probes instead of using the ping dependency and killing the app when the ldes is not responsive?

This service already uses a docker image that starts a server. c.f. https://github.com/mu-semtech/mu-javascript-template/blob/master/helpers/mu/server.js#L40

We could also provide different health checks for the app (e.g. /status/am-i-up) and the eventstream (e.g. /status/ldes). C.f. https://hootsuite.github.io/health-checks-api/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants