Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/stability improvements #42

Open
wants to merge 49 commits into
base: master
Choose a base branch
from

Conversation

gauquiebart
Copy link
Collaborator

The PR takes the latest main, merges into it several branches, and fixes several issues encountered in the ldes-consumer-service and the underlying event-stream-client (forked here: https://github.com/lblod/event-stream-client - main branch).

all changes:

A pre-release was made of this branch : https://github.com/redpencilio/ldes-consumer-service/releases/tag/vfeature-stability-improvements-r1.0 . We are currently testing the changes and planning to go into production in a few weeks.

Could you kindly review this and integrate it into the main branch when you have a moment? Thank you.

erikap and others added 30 commits February 13, 2024 14:30
…r in tests: no restart automatically from ldes container 3/ add test cases for reading from unserviceable ldes stream (both ldes pages as context)
…ult to reading-from-unserviceable-ldes-stream test to verify the recoverability of the ldes consumer
…ements

# Conflicts:
#	member-processor.ts
#	package-lock.json
…iables from docker to node process when they contain '-' characters (e.g. X-API-KEY)
…ace logging 3/ as a work-around: increase the high water mark from 1000 to 100000 - but added a todo to properly fix ... the stream back pressure issue
…ream resume) 2/ reduce high water mark to 100
… with earlier generatedAtTime appearing later in stream is not saved -> and suggesting a mode where SAVE_ALL_VERSIONS_IGNORING_TIMESTAMP_DATA (only to be combined with REPLACE_VERSIONS = false)
… to be combined with REPLACE_VERSIONS = false)
…bles 2/ Update readme.md 3/ remove some preset params from Dockerfile
… v4.0.15, which propagates errors through the stream + clean up error handling in ldes-pipeline
… v4.0.16, which propagates errors through the stream when a page returns no members (or it can not be parsed ...)
… v4.0.19, which propagates errors through the stream (verify http response status when reading a page, and throw error if non success (4xx, 5xx)) + more trace logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants