-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/stability improvements #42
Open
gauquiebart
wants to merge
49
commits into
master
Choose a base branch
from
feature/stability-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…virtuoso database using a specific stream
… blank nodes structure created)
…r in tests: no restart automatically from ldes container 3/ add test cases for reading from unserviceable ldes stream (both ldes pages as context)
…ult to reading-from-unserviceable-ldes-stream test to verify the recoverability of the ldes consumer
…no persistent state test
…ements # Conflicts: # member-processor.ts # package-lock.json
…oken convertBlankNodes
…iables from docker to node process when they contain '-' characters (e.g. X-API-KEY)
…ace logging 3/ as a work-around: increase the high water mark from 1000 to 100000 - but added a todo to properly fix ... the stream back pressure issue
…ream resume) 2/ reduce high water mark to 100
… with earlier generatedAtTime appearing later in stream is not saved -> and suggesting a mode where SAVE_ALL_VERSIONS_IGNORING_TIMESTAMP_DATA (only to be combined with REPLACE_VERSIONS = false)
… to be combined with REPLACE_VERSIONS = false)
…ent.sh + document
…bles 2/ Update readme.md 3/ remove some preset params from Dockerfile
… v4.0.15, which propagates errors through the stream + clean up error handling in ldes-pipeline
… v4.0.16, which propagates errors through the stream when a page returns no members (or it can not be parsed ...)
This reverts commit d589d09.
This reverts commit 7798d1b.
… v4.0.19, which propagates errors through the stream (verify http response status when reading a page, and throw error if non success (4xx, 5xx)) + more trace logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR takes the latest main, merges into it several branches, and fixes several issues encountered in the ldes-consumer-service and the underlying event-stream-client (forked here: https://github.com/lblod/event-stream-client - main branch).
all changes:
A pre-release was made of this branch : https://github.com/redpencilio/ldes-consumer-service/releases/tag/vfeature-stability-improvements-r1.0 . We are currently testing the changes and planning to go into production in a few weeks.
Could you kindly review this and integrate it into the main branch when you have a moment? Thank you.