-
Notifications
You must be signed in to change notification settings - Fork 30
Add Gray Mann boss for playtesting #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FortyTwoFortyTwo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally would like to have Uber Ranger and Gray Mann's minion summon code be put into ability section, so both bosses and it's minions can reuse the same code without needing to copy-paste all of it.
Not required to do my suggestion above, just would be nice to do so if you're in the mood to code all of it in.
| SaxtonHale_RegisterClass("DemoPan", VSHClassType_Boss); | ||
| SaxtonHale_RegisterClass("DemoRobot", VSHClassType_Boss); | ||
| SaxtonHale_RegisterClass("GentleSpy", VSHClassType_Boss); | ||
| SaxtonHale_RegisterClass("Graymann", VSHClassType_Boss); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling the boss "Graymann" but calling minions "GrayMann..." with caps M, keep it consistent to call all "GrayMann"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a commit to fix the inconsistency
| StrCat(sInfo, length, "\nRage"); | ||
| StrCat(sInfo, length, "\n- Damage requirement: 3000"); | ||
| StrCat(sInfo, length, "\n- Spawn a random giant robot"); | ||
| StrCat(sInfo, length, "\n- 200%% Rage: Spawn 2 random giant robots"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text says super rage gives 2 giants, but code has it listed 3 instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the oversight
| for (int i = 0; i < sizeof(g_strGrayMannRoundStart); i++) PrepareSound(g_strGrayMannRoundStart[i]); | ||
| for (int i = 0; i < sizeof(g_strGrayMannWin); i++) PrepareSound(g_strGrayMannWin[i]); | ||
| for (int i = 0; i < sizeof(g_strGrayMannLose); i++) PrepareSound(g_strGrayMannLose[i]); | ||
| for (int i = 0; i < sizeof(g_strGrayMannRage); i++) PrepareSound(g_strGrayMannRage[i]); | ||
| for (int i = 0; i < sizeof(g_strGrayMannKillScout); i++) PrepareSound(g_strGrayMannKillScout[i]); | ||
| for (int i = 0; i < sizeof(g_strGrayMannKillSniper); i++) PrepareSound(g_strGrayMannKillSniper[i]); | ||
| for (int i = 0; i < sizeof(g_strGrayMannKillDemoMan); i++) PrepareSound(g_strGrayMannKillDemoMan[i]); | ||
| for (int i = 0; i < sizeof(g_strGrayMannKillMedic); i++) PrepareSound(g_strGrayMannKillMedic[i]); | ||
| for (int i = 0; i < sizeof(g_strGrayMannKillSpy); i++) PrepareSound(g_strGrayMannKillSpy[i]); | ||
| for (int i = 0; i < sizeof(g_strGrayMannKillEngie); i++) PrepareSound(g_strGrayMannKillEngie[i]); | ||
| for (int i = 0; i < sizeof(g_strGrayMannLastMan); i++) PrepareSound(g_strGrayMannLastMan[i]); | ||
| for (int i = 0; i < sizeof(g_strGrayMannBackStabbed); i++) PrepareSound(g_strGrayMannBackStabbed[i]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Folder directory have it named /graymann/, but all of these have it as /grayman/ instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed that due to already having the sounds downloaded, pathfile is fixed now
| AddFileToDownloadsTable("sound/vsh_rewrite/graymann/intro1.mp3"); | ||
| AddFileToDownloadsTable("sound/vsh_rewrite/graymann/intro2.mp3"); | ||
| AddFileToDownloadsTable("sound/vsh_rewrite/graymann/intro3.mp3"); | ||
| AddFileToDownloadsTable("sound/vsh_rewrite/graymann/lastman1.mp3"); | ||
| AddFileToDownloadsTable("sound/vsh_rewrite/graymann/lastman2.mp3"); | ||
| AddFileToDownloadsTable("sound/vsh_rewrite/graymann/laugh1.mp3"); | ||
| AddFileToDownloadsTable("sound/vsh_rewrite/graymann/laugh2.mp3"); | ||
| AddFileToDownloadsTable("sound/vsh_rewrite/graymann/laugh3.mp3"); | ||
| AddFileToDownloadsTable("sound/vsh_rewrite/graymann/rage1.mp3"); | ||
| AddFileToDownloadsTable("sound/vsh_rewrite/graymann/rage2.mp3"); | ||
| AddFileToDownloadsTable("sound/vsh_rewrite/graymann/rage3.mp3"); | ||
| AddFileToDownloadsTable("sound/vsh_rewrite/graymann/lose.mp3"); | ||
| AddFileToDownloadsTable("sound/vsh_rewrite/graymann/win.mp3"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need to list sounds when PrepareSound above should already be listing it to downloads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed these Downloads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need .sw.vtx file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted in the commit
fixed collisions, sound issues, and a lot of other robot related bugs
| StrCat(sInfo, length, "\nAbilities"); | ||
| StrCat(sInfo, length, "\n- Killing people turns them into gold, and you siphon their power to heal yourself for 250 HP flat"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to mention the mini super jump here
FortyTwoFortyTwo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MvM real
Adds "Gray Mann", a new boss with the lowest(?) health pool out of any active boss in rotation