Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size-limit config #2173

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Conversation

aryaemami59
Copy link
Contributor

This PR:

  • Adds size-limit config to monitor bundle size changes in preparation for any potential changes we'll have to make to migrate to React 19.

Copy link

codesandbox-ci bot commented May 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@timdorr
Copy link
Member

timdorr commented May 16, 2024

Honestly, I'm not a huge fan of these sorts of tools. They tend to be more annoying than helpful. Maybe we can limit it to just a react19 branch, so we don't have to tend to it after we complete that work?

Edit: Wait, don't we already have this? https://github.com/reduxjs/react-redux/blob/master/.github/workflows/size.yaml

@aryaemami59
Copy link
Contributor Author

@timdorr

Honestly, I'm not a huge fan of these sorts of tools. They tend to be more annoying than helpful.

That's fair, but size-limit does give us an idea of how the changes that we make impact our bundle sizes. And with the way I setup the config, it can keep track of every single named export, in every single package entry point, in both development and production builds. And the config is simple enough that I hope we'd be able to insert into any one of the redux packages and it should just work.

Edit: Wait, don't we already have this? https://github.com/reduxjs/react-redux/blob/master/.github/workflows/size.yaml

While preactjs/compressed-size-action does give us some info about bundle size changes, it looks like it's only looking at dist/cjs/index.js and dist/react-redux.legacy-esm.js. It also doesn't look at named exports, or different environments.

The idea is to have this here so that if we were ever to make a set of changes, we could use it to keep an eye on bundle sizes, it doesn't necessarily have to put a "limit" on anything.

@EskiMojo14
Copy link
Collaborator

yeah, while I don't think the concept of a size "limit" is very useful, I do find it useful to have visibility on how a given set of changes affects final bundle size.

@timdorr
Copy link
Member

timdorr commented May 17, 2024

Could this supplant our usage of compressed-size-action? That one hasn't been updated in a long time and causes some warnings in CI that will eventually turn into errors, so it's been on my radar to replace it.

@aryaemami59
Copy link
Contributor Author

I guess we could use https://github.com/EskiMojo14/size-limit-action, same thing we're doing with RTK.

Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for react-redux-docs ready!

Name Link
🔨 Latest commit bdaffcd
🔍 Latest deploy log https://app.netlify.com/sites/react-redux-docs/deploys/66bfddc6a1b3d600086c804a
😎 Deploy Preview https://deploy-preview-2173--react-redux-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@markerikson
Copy link
Contributor

Yeah, I think we want to switch to the other size package for consistency.

@aryaemami59
Copy link
Contributor Author

The other size package?

@markerikson
Copy link
Contributor

@aryaemami59 aryaemami59 force-pushed the add-size-limit branch 17 times, most recently from c1b6e60 to 424ba39 Compare September 17, 2024 12:27
Copy link

@scottpolo scottpolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aryaemami59 aryaemami59 force-pushed the add-size-limit branch 10 times, most recently from d2adae6 to 01c1ca8 Compare October 3, 2024 09:46
@timdorr
Copy link
Member

timdorr commented Oct 3, 2024

Note: The action is failing because we don't have size-limit on master. Once this lands, that error goes away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants