Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to @typescript-eslint version that supports TypeScript 5.6.2 #11878

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented Jan 6, 2025

The current version did trigger the following warning whenever executing yarn rw lint:

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.6.0

YOUR TYPESCRIPT VERSION: 5.6.2

Please only submit bug reports when using the officially supported version.

IMHO this should be released into the v8 branch, as that introduced the TS version that was unsupported.

I may base another PR on this one updating the other linting related deps which will be less critical to get into v8.

This PR updates all @typescript-eslint packages together, as the releases are tethered, according to their versioning strategy docs:

All of the packages in this project are published with the same version number to make it easier to coordinate both releases and installations.

@Philzen Philzen changed the title Fix TS version warning by updating @typescript-eslint/parser to v8.19.0 Fix TS version warning by updating @typescript-eslint packages to v8.19.0 Jan 6, 2025
@Philzen Philzen force-pushed the bugfix/fix-lint-ts-version-warning-by-updating-@typescript-eslint/parser branch 2 times, most recently from 52b8a6f to 396e541 Compare January 8, 2025 00:49
The current version did trigger the following warning whenever executing
`yarn rw lint`:

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.6.0

YOUR TYPESCRIPT VERSION: 5.6.2

Please only submit bug reports when using the officially supported version.
These gave actual errors

> Unexpected `for await...of` of a value that is not async iterable.eslint

… for a good reason. This rule was properly introduced in @typescript/eslint
v8.8.0, see
typescript-eslint/typescript-eslint#10008
@Philzen Philzen force-pushed the bugfix/fix-lint-ts-version-warning-by-updating-@typescript-eslint/parser branch from 396e541 to 6914b03 Compare January 8, 2025 01:57
@Philzen Philzen changed the title Fix TS version warning by updating @typescript-eslint packages to v8.19.0 Fix TS version warning by updating @typescript-eslint packages to v8.19.1 Jan 8, 2025
@Philzen Philzen changed the title Fix TS version warning by updating @typescript-eslint packages to v8.19.1 Update to @typescript-eslint version that supports TypeScript 5.6.2 Jan 8, 2025
@Tobbe Tobbe added the release:dependency This PR only updates dependencies label Jan 15, 2025
@Tobbe Tobbe modified the milestones: chore, next-release-patch Jan 15, 2025
@Tobbe Tobbe enabled auto-merge (squash) January 15, 2025 07:40
@Tobbe Tobbe merged commit 56c712a into redwoodjs:main Jan 15, 2025
45 of 49 checks passed
@Philzen Philzen deleted the bugfix/fix-lint-ts-version-warning-by-updating-@typescript-eslint/parser branch January 15, 2025 14:12
Tobbe added a commit that referenced this pull request Jan 16, 2025
@Tobbe Tobbe modified the milestones: next-release-patch, v8.4.3 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:dependency This PR only updates dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants