Constance metrics+datetime #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variables from CONSTANCE_CONFIG will be exported as Prometheus metrics, starting with the default prefix of "constance_config_"
Not all string characters are allowed in metric names. Try to replace them with underscores.
The Enum type is being dropped in multiprocess mode and Gauge is perfectly enough to represent booleans
As ideated in the CR, there could be two functions: - one which stores a single monitored variable, - another which stores all of them. This commit implements them.
msalaban-reef
force-pushed
the
constance-metrics+datetime
branch
from
05daa65 to
cc5b95c
Compare
|
This pull request introduces 2 alerts and fixes 1 when merging cc5b95c into b54e5b6 - view on LGTM.com new alerts:
fixed alerts:
|
THIS IS A HACK: To avoid key clash, try to reuse an existing metric by using undocumented mapping in the registry.
The ``datetime`` and ``date`` objects are being converted to UNIX timestamps (with ``date`` defaulting to noon) and exported rounded to integers. The ``time`` and ``timedelta`` get represented as the number of seconds, rounded to integers.
msalaban-reef
force-pushed
the
constance-metrics+datetime
branch
from
cc5b95c to
bb84355
Compare
|
This pull request introduces 2 alerts and fixes 1 when merging bb84355 into b54e5b6 - view on LGTM.com new alerts:
fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to PR #73, an implementation of handling
datetime.*types as proposed by @ppolewicz