Repository navigation
fix(docs): improve Stack and Foreach demo contrast - #7876
FarhanAliRaza wants to merge 1 commit into
Conversation
[Low impact] The code appears safe to merge; the author’s planned visual checks remain pending. SummaryThis PR improves label contrast in the Stack and Foreach documentation demos and adds source-based regression tests.
No actionable issues found. FarhanAliRaza explicitly leaves browser checks and after screenshots pending, keeps the PR draft, and defers updating #7872’s color expectations until integration. Reviews (1) · Last reviewed commit: "fix(docs): keep fixed-color demo labels ..." · Reviewed by Greptile |
Merging this PR will regress 2 benchmarks2 warnings
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing |
Summary
docs/styling/layout.md(WEB-013). This is not the component-reference page already fixed by Fix dark-mode contrast in the layout component demos #7676.Existing fix / overlap checks
Checked current main
c2d50fb2cb75c69fd11c82bef7e76efd800db8cfand open PR searches. #7676 fixes separatedocs/library/layout/pages, not this styling guide. #7657 fixes the Foreach todo/grid but not these swatches.#7872 adds browser assertions for the old swatch hex/RGB values without fixing contrast. Its expectations must be updated to this palette when the branches are integrated (red
rgb(206, 44, 49), tealrgb(0, 133, 115), orangergb(204, 78, 0)). This PR deliberately does not duplicate its browser-test infrastructure.Validation
ruff check .passed; new test formatting andgit diff --checkpassed.pyright reflex tests: one error in unchangedtests/units/docgen/test_class_and_component.py:397(field overload), plus two pre-existing unused-expression warnings.socket() failed: Operation not permitted. A supported local docs preview was also attempted after installing its dependencies, but stops becausereflex-enterpriserequires login orREFLEX_ACCESS_TOKEN; no preview was launched. No deployed-fix claim.Before / after screenshots
Pending. Keep this PR draft. Genuine live before captures exist from the bug hunt; after captures require an accessible branch preview. Screenshot attachment/visual verification is an explicit completion requirement, not waived by passing source tests.
Review
Focused source review found no changes to public APIs or demo interactions. Remaining review concern: coordinate the literal color expectations with #7872. Nothing merged or deployed.