Skip to content

test: add required Bun-only and outdated Node integration coverage - #7899

Open
somiljain2006 wants to merge 4 commits into
reflex-dev:mainfrom
somiljain2006:bun
Open

somiljain2006 wants to merge 4 commits into
reflex-dev:mainfrom
somiljain2006:bun

Conversation

@somiljain2006

@somiljain2006 somiljain2006 commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Closes #7896

Add dedicated Linux, macOS, and Windows CI coverage for Bun-only frontend startup. Explicitly install Bun, verify startup without Node and with an outdated Node version, fail CI on missing prerequisites or skipped tests, and record runtime versions.

View guided diff

@somiljain2006
somiljain2006 requested a review from a team as a code owner November 14, 2026 16:40
@greptile-apps

greptile-apps Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The latest change appears safe to merge; no new blocking issues were found.

Summary

Adds required Bun startup checks on Linux, macOS, and Windows, covering both missing and outdated Node installations.

  • CI checks Bun frontend startup across three operating systems.

Earlier threads about partial page checks and bare Python commands were manually resolved by somiljain2006 without explanation. somiljain2006 accepted the small repeated assertion blocks because the tests cover different setups and remain easier to read separately; Greptile withdrew that suggestion. No new findings.

Reviews (3) · Last reviewed commit: "Add the same monkeypatch.delenv to nodel..." · Reviewed by Greptile

Comment thread .github/workflows/integration_tests.yml Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic

@codspeed

codspeed Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ 10 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 143 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing somiljain2006:bun (504de44) with main (8e5bb84)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Bun-only frontend regression test skips in Linux jobs; cover macOS and outdated Node

1 participant