Repository navigation
Treat None as an empty string in optional StringVar operations #7902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FarhanAliRaza
wants to merge
2
commits into
main
Choose a base branch
from
ccr-b5f6d6c1-k1ong5-optional-str-none
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+162
−16
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Methods of an optional string var (`str | None`) holding `None` no longer crash the page or the production prerender: the string acts as an empty string, so each method gives what it gives for `""`. For example, `lower` gives an empty string, `contains("a")` is false and `split(" ")` gives `[""]`. Before, the methods compiled to a native string method (`split` with a separator, `strip`, `lower`, `upper`, `contains`, ...) threw `Cannot read properties of null`, while `length`, indexing and slicing already read `None` as empty. Concatenation with `+` and the comparison operators are unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Concatenation is still unguarded, so
None + "x"renders as"nullx"in the browser. The new docs and news entry say an optional string holdingNoneacts as""in every string operation, so guard__add__and__radd__with_or_empty()as the array__add__does. The ordering comparisons (<,>,<=,>=) have the same gap, so either guard them or narrow the docs claim.Prompt for AI agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Narrowed the claim instead of guarding
+(cbd9751): the docs and the news fragment now say the string methods readNoneas"", and name+and the comparison operators as not covered.I left
+alone on purpose. An f-string (f"{S.m} x") builds the same concatenation without going through__add__, so guarding__add__/__radd__would makeS.m + " x"andf"{S.m} x"render differently for the same value. Neither throws, so it is outside what #7873 is about (operations that crash the page); changing what aNonerenders as in concatenation is a separate decision for both forms together.Generated by Claude Code