Skip to content

Crash when calling "stopListeningToAll" on a store listening to other stores #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
solerbartomeu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Crash when calling "stopListeningToAll" on a store listening to other stores #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc7e628
Fixed crash when calling stopListeningTo on a store that listens to m…
Mar 29, 2016
9f29a95
Added compatibility with older way of using
Mar 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/ListenerMethods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,11 @@ export default {
_.throwIf(this.validateListening(listenable));
this.fetchInitialState(listenable, defaultCallback);
desub = listenable.listen(this[callback] || callback, this);
unsubscriber = function() {
var index = subs.indexOf(subscriptionobj);
unsubscriber = function(listenerSubs) {
var currentSubs = listenerSubs ? listenerSubs : subs;
var index = currentSubs.indexOf(subscriptionobj);
_.throwIf(index === -1, "Tried to remove listen already gone from subscriptions list!");
subs.splice(index, 1);
currentSubs.splice(index, 1);
desub();
};
subscriptionobj = {
Expand All @@ -143,7 +144,7 @@ export default {
for(;i < subs.length; i++){
sub = subs[i];
if (sub.listenable === listenable){
sub.stop();
sub.stop(subs);
_.throwIf(subs.indexOf(sub) !== -1, "Failed to remove listen from subscriptions list!");
return true;
}
Expand All @@ -157,7 +158,7 @@ export default {
stopListeningToAll: function(){
var remaining, subs = this.subscriptions || [];
while((remaining = subs.length)){
subs[0].stop();
subs[0].stop(subs);
_.throwIf(subs.length !== remaining - 1, "Failed to remove listen from subscriptions list!");
}
},
Expand Down