feature/zero-copy-collections#12
Open
ebrightfield wants to merge 6 commits intoregolith-labs:masterfrom
Open
Conversation
eb144a5 to
f763cf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Note: This is an alternative implementation of the previous
Header*traits I drafted. I'm not sure whether this is better, main "objective improvement" in this PR is just working it intoAsAccount.One of the pain points of
Podaccount data is storing collections of items, especially collections whose lengths may differ across different accounts.More generally, lots of times it's nice to "parse a header first, then parse the rest," as demonstrated by programs in the wild like Bonfida's agnostic-orderbook, SPL Account Compression, or this random dude's account history program.
In Steel's case, the header type can be
Discriminator + Pod. Then, using the header, the remaining bytes can be deserialized. For example, collections could resolve to either generically sized arrays, or structs with slices whose lengths are stored in the header. This PR provides a way to define these fancy "two-step" types with theAsAccountinterface.Implementation
AsAccountinterface.FromHeaderandFromHeaderMut. Removed the old header-related traits.FromHeader<'_, T>orFromHeaderMut<'_, T>for someT: AccountDeserializecan be used in the following ways:A Couple Call-Outs