Skip to content

Adding webview share button control to button_type 'web_url' #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Loukious wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Adding webview share button control to button_type 'web_url' #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8cc702f
Adding webview share button control to button_type 'web_url'
Loukious Feb 26, 2020
91d4d82
adding profanity filter
Loukious Oct 9, 2020
e72ba84
typo
Loukious Oct 9, 2020
8f40ef2
testing
Loukious Oct 9, 2020
e99f6aa
trying to fix
Loukious Oct 9, 2020
50d7964
revert
Loukious Oct 9, 2020
3f5146f
revert the whole thing
Loukious Oct 9, 2020
846da23
revert
Loukious Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fbmessenger/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

DEFAULT_API_VERSION = 2.12


class MessengerClient(object):

# https://developers.facebook.com/docs/messenger-platform/send-messages#messaging_types
Expand Down Expand Up @@ -79,6 +78,7 @@ def get_user_data(self, recipient_id, fields=None, timeout=None):

def send(self, payload, recipient_id, messaging_type='RESPONSE', notification_type='REGULAR',
timeout=None, tag=None):

if messaging_type not in self.MESSAGING_TYPES:
raise ValueError('`{}` is not a valid `messaging_type`'.format(messaging_type))

Expand Down
7 changes: 6 additions & 1 deletion fbmessenger/elements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class Button(object):
]

def __init__(self, button_type, title=None, url=None,
payload=None, webview_height_ratio=None,
payload=None, webview_height_ratio=None, webview_share_button=None,
messenger_extensions=None, fallback_url=None,
share_contents=None):

Expand All @@ -75,12 +75,15 @@ def __init__(self, button_type, title=None, url=None,
if title and len(title) > 20:
logger.warning(CHARACTER_LIMIT_MESSAGE.format(field='Title',
maxsize=20))
if button_type != 'web_url' and webview_share_button is not None:
raise ValueError('`webview_share_button` is only valid for button type `web_url`')

self.button_type = button_type
self.title = title
self.url = url
self.payload = payload
self.webview_height_ratio = webview_height_ratio
self.webview_share_button = webview_share_button
self.messenger_extensions = messenger_extensions
self.fallback_url = fallback_url
self.share_contents = share_contents
Expand All @@ -101,6 +104,8 @@ def to_dict(self):
d['webview_height_ratio'] = self.webview_height_ratio
if self.messenger_extensions:
d['messenger_extensions'] = 'true'
if self.webview_share_button is False:
d['webview_share_button'] = 'hide'
if self.fallback_url:
d['fallback_url'] = self.fallback_url
if self.button_type == 'element_share':
Expand Down
3 changes: 3 additions & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,6 @@ tqdm==4.23.4
twine==1.11.0
urllib3==1.23
wrapt==1.10.11
profanity-filter==1.3.3
spacy==2.3.2
https://github.com/explosion/spacy-models/releases/download/en_core_web_sm-2.3.1/en_core_web_sm-2.3.1.tar.gz#egg=en_core_web_sm