Skip to content

Conversation

@1-leo
Copy link
Contributor

@1-leo 1-leo commented Jul 15, 2025

No description provided.

@1-leo 1-leo self-assigned this Jul 15, 2025
@1-leo 1-leo added the enhancement New feature or request label Jul 15, 2025
@1-leo 1-leo added this to ndk-dev Jul 15, 2025
@1-leo 1-leo moved this to In Progress in ndk-dev Jul 15, 2025
@1-leo 1-leo added this to the 0.6 milestone Jul 15, 2025
@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

❌ Patch coverage is 78.45023% with 381 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.52%. Comparing base (2c8492e) to head (2f1d5fe).

Files with missing lines Patch % Lines
...ndk/lib/domain_layer/usecases/wallets/wallets.dart 44.88% 70 Missing ⚠️
...ges/ndk/lib/domain_layer/usecases/cashu/cashu.dart 87.25% 52 Missing ⚠️
...data_layer/repositories/cashu/cashu_repo_impl.dart 75.40% 45 Missing ⚠️
..._layer/repositories/wallets/wallets_repo_impl.dart 58.97% 32 Missing ⚠️
...main_layer/entities/wallet/wallet_transaction.dart 57.37% 26 Missing ⚠️
.../repositories/cache_manager/mem_cache_manager.dart 70.23% 25 Missing ⚠️
...s/ndk/lib/domain_layer/entities/wallet/wallet.dart 26.08% 17 Missing ⚠️
.../lib/domain_layer/entities/cashu/cashu_keyset.dart 76.36% 13 Missing ⚠️
...in_layer/usecases/cashu/cashu_cache_decorator.dart 60.60% 13 Missing ⚠️
...b/domain_layer/entities/cashu/cashu_mint_info.dart 90.08% 12 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
+ Coverage   68.58%   71.52%   +2.93%     
==========================================
  Files         126      157      +31     
  Lines        4473     6241    +1768     
==========================================
+ Hits         3068     4464    +1396     
- Misses       1405     1777     +372     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@1-leo
Copy link
Contributor Author

1-leo commented Jul 16, 2025

As a user I want to donate ecash without fees
(locked token to pubkey without swap)

@1-leo 1-leo modified the milestones: 0.6, 0.7 Nov 12, 2025
# Conflicts:
#	doc/usecases/lists.md
#	packages/isar/pubspec.lock
#	packages/ndk/example/nip13_pow_example.dart
#	packages/sample-app/pubspec.lock
Copy link
Collaborator

@frnandu frnandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • cashu tests need to be somehow be fixed
  • unskipp tests that were for some reason skipped
  • add send/receive lightning methods to operations repo (I'll be doing this next)

BehaviorSubject<List<CashuWalletTransaction>>.seeded([]);

/// stream of balances \
BehaviorSubject<List<CashuMintBalance>>? _balanceSubject;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this need to be cleaned on destroy/dispose?

@frnandu frnandu marked this pull request as draft December 3, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

4 participants