Skip to content

Remove throw exception #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nogringo merged 1 commit into from
Dec 10, 2025
Merged

Remove throw exception #333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions packages/ndk/lib/domain_layer/usecases/relay_manager.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,16 +360,23 @@ class RelayManager<T> {
relayConnectivity,
);
}, onError: (error) async {
await relayConnectivity.close();
relayConnectivity.stats.connectionErrors++;
Logger.log.e("onError ${relayConnectivity.url} on listen $error");
relayConnectivity.stats.connectionErrors++;
try {
await relayConnectivity.close();
} catch (e) {
Logger.log.w("Error closing relay ${relayConnectivity.url}: $e");
}
updateRelayConnectivity();
throw Exception("Error in socket");
}, onDone: () async {
Logger.log.t(
"onDone ${relayConnectivity.url} on listen (close: ${relayConnectivity.relayTransport!.closeCode()} ${relayConnectivity.relayTransport!.closeReason()})");
"onDone ${relayConnectivity.url} on listen (close: ${relayConnectivity.relayTransport?.closeCode()} ${relayConnectivity.relayTransport?.closeReason()})");

await relayConnectivity.close();
try {
await relayConnectivity.close();
} catch (e) {
Logger.log.w("Error closing relay ${relayConnectivity.url}: $e");
}
updateRelayConnectivity();
// reconnect on close
if (allowReconnectRelays &&
Expand Down