Skip to content

fix: use isolate.run in bip340 event verifier #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frnandu wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: use isolate.run in bip340 event verifier #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
106de04
use isolate.run
frnandu Dec 22, 2025
8ab39e9
add useIsolate as an optional constructor param for configuration
frnandu Dec 22, 2025
1b3c2e7
Merge branch 'master' into fix/bip340-isolate
frnandu Jan 13, 2026
38ab224
rollback
frnandu Jan 14, 2026
f463223
Merge branch 'master' into fix/bip340-isolate
frnandu Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/ndk/lib/data_layer/repositories/verifiers/bip340_event_verifier.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import 'dart:isolate';

import 'package:bip340/bip340.dart' as bip340;

import '../../../domain_layer/entities/nip_01_event.dart';
Expand All @@ -6,11 +8,18 @@ import '../../../domain_layer/repositories/event_verifier.dart';
/// Pure dart event verifier using https://pub.dev/packages/bip340
/// can be slow on mobile devices
class Bip340EventVerifier implements EventVerifier {
bool useIsolate = true;

Bip340EventVerifier({this.useIsolate = true});

@override
Future<bool> verify(Nip01Event event) async {
if (event.sig == null) {
return false;
}
return bip340.verify(event.pubKey, event.id, event.sig!);
if (!event.isIdValid) return false;
return useIsolate? await Isolate.run(() {
return bip340.verify(event.pubKey, event.id, event.sig);
}) : bip340.verify(event.pubKey, event.id, event.sig);
}
}
16 changes: 8 additions & 8 deletions packages/sample-app/lib/query_performance.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,10 @@ class _QueryPerformancePageState extends State<QueryPerformancePage> {
onPressed: _isVerifyingBip340 ? null : _runBip340Query,
child: _isVerifyingBip340
? const SizedBox(
height: 20,
width: 20,
child: CircularProgressIndicator(strokeWidth: 2),
)
height: 20,
width: 20,
child: CircularProgressIndicator(strokeWidth: 2),
)
: const Text('Run with BIP340'),
),
const SizedBox(height: 8),
Expand All @@ -139,10 +139,10 @@ class _QueryPerformancePageState extends State<QueryPerformancePage> {
onPressed: _isVerifyingRust ? null : _runRustQuery,
child: _isVerifyingRust
? const SizedBox(
height: 20,
width: 20,
child: CircularProgressIndicator(strokeWidth: 2),
)
height: 20,
width: 20,
child: CircularProgressIndicator(strokeWidth: 2),
)
: const Text('Run with Rust'),
),
const SizedBox(height: 8),
Expand Down
Loading