Add filelist and get_files() to RpmUnit [RHELDST-34141] #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drepelov
force-pushed
the
combine_files
branch
from
3ae902e to
04569ab
Compare
rbikar
requested changes
Sep 18, 2025
This commit adds a `filelist` attr to RpmUnit, which maps to file paths from Pulp `repodata.filelists` field. Moreover, it adds a `get_files()` method to RpmUnit, which returns combined data from this new `filelist`and `files` attrs. This is to be used in ubi-manifest, to avoid reporting false positive file depsolving warnings, because there are cases in which the `files.file` field is missing.
drepelov
force-pushed
the
combine_files
branch
from
04569ab to
5c477b4
Compare
drepelov
changed the title
rbikar
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
filelistattr to RpmUnit, which maps to file paths from Pulprepodata.filelistsfield.Moreover, it adds a
get_files()method to RpmUnit, which returns combined data from this newfilelistandfilesattrs.This is to be used in ubi-manifest, to avoid reporting false positive file depsolving warnings, because there are cases in which the
files.filefield is missing.