Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use generic types for cy.then and cy.get aliases #260

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

antonkri97
Copy link

Hey all!

This is a small pr that, it seems to me, slightly improves the typing in Cypress when using aliases.

This is a move away from type assertion to a slightly more formal system.

This can help developers immediately see the format for working with aliases in their projects.

I was inspired by this cypress-io/cypress#8762 (comment).

This is how I made it work in my application.
https://github.com/antonkri97/family/pull/7/files#diff-ecc0256f03e3c2246926d3533817ed8df3416df522a4edee7b89a27a972d56a8

I moved all the aliases into a separate file. If you think it's a good idea, I could put these types in a separate place too.

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant