Add MSW setup instructions #292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@petecartwright I can't seem to reproduce the problem you're explaining. Tagging @kettanaito (the creator/maintainer of MSW) to know if we would need to add the created |
|
Hm - thanks for looking! I can try to reproduce locally tomorrow. If I can’t replicate, I’ll close and we can pretend this never happened. 😀 |
|
Closing, see #291 for a little more context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #291 for some additional details.
With the current setup guide, users will get 404s in their terminal looking for
mockServiceWorker.js.This PR adds
msw initto the setup guide, and adds the generatedpublic/mockServiceWorker.jsfile to.gitignoreand.dockerignoreto minimize likelihood of it getting packaged for prod.I went back and forth on whether this makes more sense in the
## Developmentsection, or as a new### Mockingsection under## Testing. Happy to make that change or any rephrase y'all prefer.