-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
fix(dev/vite/plugin): fix p-map import
#14492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dev/vite/plugin): fix p-map import
#14492
Conversation
🦋 Changeset detectedLatest commit: 6b94e85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @HeyyyNeo, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
07aa497 to
65debd2
Compare
|
Thank you for the PR @HeyyyNeo! Would you mind rebasing this onto |
|
sure thing @brophdawg11 |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
b06a2b3 to
ed4359c
Compare
|
@brophdawg11 can you please recheck? |
|
@timdorr i am new to open source Pull Request practices, is there anything pending? or this PR is ready to be merged? |
|
@HeyyyNeo We use Changesets to auto-generate the |
ed4359c to
2570e10
Compare
p-map import
2570e10 to
41cd8ea
Compare
f07fd23 to
cb9eab7
Compare
|
done @brophdawg11 . Please revalidate |
cb9eab7 to
582f9a7
Compare
582f9a7 to
fcc5729
Compare
|
It doens't look like you ran I made the updates and pushed to this branch to get things straightened out so we can get this merged 👍 |
|
@brophdawg11 this is what i ran
|
e0886b9 to
47f3467
Compare
47f3467 to
6b94e85
Compare
|
you only needed to run
|
I am able to run the project after changing esm import to dynamic import
Fixes : #14489
This piece of granular code fixes the issue: (Did changes directly in minified js code)
Steps taken to validate the fix
Build is same as previous

How is it verified
In this current project i ran the build and copied the vite.js content and pasted in my own project
Both node v20, v25 runs the project seamlessly