Update to Remix 2.12.0 #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brophdawg11
changed the title
brophdawg11
reviewed
Sep 12, 2024
| } | ||
|
|
||
| return json({ error: null, ok: true }); | ||
| return data({ error: null, ok: true }); |
There was a problem hiding this comment.
This and the prior one don't need data() because they don't care about the status but there's a known issue in our type inference that doesn't like the mixing and matching of data/json/etc. and raw objects so using data everywhere to avoid that.
There was a problem hiding this comment.
I left a comment on the RR PR, should have read this one first.
Thanks for the explanation!
brophdawg11
reviewed
Sep 12, 2024
| @@ -156,7 +152,7 @@ export default function DocPage() { | |||
| ); | |||
| } | |||
|
|
|||
| function LargeOnThisPage({ doc }: { doc: SerializeFrom<Doc> }) { | |||
| function LargeOnThisPage({ doc }: { doc: Doc }) { | |||
There was a problem hiding this comment.
With Single Fetch now we just get back a Doc
brophdawg11
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.