-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove @remix-run/eslint-config dependency (#7597)
- Loading branch information
1 parent
166d13d
commit e8dd645
Showing
32 changed files
with
826 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| #!/bin/bash | ||
|
|
||
| # Helper script for us to use to validate template lint setups outside of the | ||
| # monorepo. This script will, for each template in your local Remix repo clone: | ||
| # | ||
| # * Install an app via create-remix for the template (into a temp/ directory) | ||
| # * Install deps | ||
| # * npm run lint | ||
| # | ||
| # Usage: | ||
| # lint-templates.sh [path-to-remix-repo] | ||
| # | ||
| # So from a sibling folder to the remix repo: | ||
| # ../remix/scripts/lint-templates.sh ../remix | ||
|
|
||
| REPO_DIR="${1}" | ||
|
|
||
| if [ "${REPO_DIR}" == "" ]; then | ||
| REPO_DIR="../remix" | ||
| fi | ||
|
|
||
| if [ ! -e "${REPO_DIR}" ]; then | ||
| echo "Invalid repo directory: ${REPO_DIR}"; | ||
| exit 1; | ||
| fi | ||
|
|
||
| TEMPLATES=$(find ${REPO_DIR}/templates -type d -mindepth 1 -maxdepth 1 | grep -v deno | grep -v tutorial | sort) | ||
|
|
||
| for D in ${TEMPLATES}; do | ||
| echo "Linting template: ${D}"; | ||
| echo "-------------------------------------------------------"; | ||
| rm -rf temp; | ||
| npx create-remix@latest --template "${D}" temp -y; | ||
| cd temp; | ||
| npm run lint; | ||
| echo ""; | ||
| echo ""; | ||
| cd ..; | ||
| done |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,80 @@ | ||
| /** | ||
| * This is intended to be a basic starting point for linting in your app. | ||
| * It relies on recommended configs out of the box for simplicity, but you can | ||
| * and should modify this configuration to best suit your team's needs. | ||
| */ | ||
|
|
||
| /** @type {import('eslint').Linter.Config} */ | ||
| module.exports = { | ||
| extends: ["@remix-run/eslint-config", "@remix-run/eslint-config/node"], | ||
| root: true, | ||
| parserOptions: { | ||
| ecmaVersion: "latest", | ||
| sourceType: "module", | ||
| ecmaFeatures: { | ||
| jsx: true, | ||
| }, | ||
| }, | ||
| env: { | ||
| browser: true, | ||
| commonjs: true, | ||
| es6: true, | ||
| }, | ||
|
|
||
| // Base config | ||
| extends: ["eslint:recommended"], | ||
|
|
||
| overrides: [ | ||
| // React | ||
| { | ||
| files: ["**/*.{js,jsx,ts,tsx}"], | ||
| plugins: ["react", "jsx-a11y"], | ||
| extends: [ | ||
| "plugin:react/recommended", | ||
| "plugin:react/jsx-runtime", | ||
| "plugin:react-hooks/recommended", | ||
| "plugin:jsx-a11y/recommended", | ||
| ], | ||
| settings: { | ||
| react: { | ||
| version: "detect", | ||
| }, | ||
| formComponents: ["Form"], | ||
| linkComponents: [ | ||
| { name: "Link", linkAttribute: "to" }, | ||
| { name: "NavLink", linkAttribute: "to" }, | ||
| ], | ||
| }, | ||
| }, | ||
|
|
||
| // Typescript | ||
| { | ||
| files: ["**/*.{ts,tsx}"], | ||
| plugins: ["@typescript-eslint", "import"], | ||
| parser: "@typescript-eslint/parser", | ||
| settings: { | ||
| "import/internal-regex": "^~/", | ||
| "import/resolver": { | ||
| node: { | ||
| extensions: [".ts", ".tsx"], | ||
| }, | ||
| typescript: { | ||
| alwaysTryTypes: true, | ||
| }, | ||
| }, | ||
| }, | ||
| extends: [ | ||
| "plugin:@typescript-eslint/recommended", | ||
| "plugin:import/recommended", | ||
| "plugin:import/typescript", | ||
| ], | ||
| }, | ||
|
|
||
| // Node | ||
| { | ||
| files: [".eslintrc.js", "plugin-remix.js"], | ||
| env: { | ||
| node: true, | ||
| }, | ||
| }, | ||
| ], | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,80 @@ | ||
| /** | ||
| * This is intended to be a basic starting point for linting in your app. | ||
| * It relies on recommended configs out of the box for simplicity, but you can | ||
| * and should modify this configuration to best suit your team's needs. | ||
| */ | ||
|
|
||
| /** @type {import('eslint').Linter.Config} */ | ||
| module.exports = { | ||
| extends: ["@remix-run/eslint-config", "@remix-run/eslint-config/node"], | ||
| root: true, | ||
| parserOptions: { | ||
| ecmaVersion: "latest", | ||
| sourceType: "module", | ||
| ecmaFeatures: { | ||
| jsx: true, | ||
| }, | ||
| }, | ||
| env: { | ||
| browser: true, | ||
| commonjs: true, | ||
| es6: true, | ||
| }, | ||
|
|
||
| // Base config | ||
| extends: ["eslint:recommended"], | ||
|
|
||
| overrides: [ | ||
| // React | ||
| { | ||
| files: ["**/*.{js,jsx,ts,tsx}"], | ||
| plugins: ["react", "jsx-a11y"], | ||
| extends: [ | ||
| "plugin:react/recommended", | ||
| "plugin:react/jsx-runtime", | ||
| "plugin:react-hooks/recommended", | ||
| "plugin:jsx-a11y/recommended", | ||
| ], | ||
| settings: { | ||
| react: { | ||
| version: "detect", | ||
| }, | ||
| formComponents: ["Form"], | ||
| linkComponents: [ | ||
| { name: "Link", linkAttribute: "to" }, | ||
| { name: "NavLink", linkAttribute: "to" }, | ||
| ], | ||
| }, | ||
| }, | ||
|
|
||
| // Typescript | ||
| { | ||
| files: ["**/*.{ts,tsx}"], | ||
| plugins: ["@typescript-eslint", "import"], | ||
| parser: "@typescript-eslint/parser", | ||
| settings: { | ||
| "import/internal-regex": "^~/", | ||
| "import/resolver": { | ||
| node: { | ||
| extensions: [".ts", ".tsx"], | ||
| }, | ||
| typescript: { | ||
| alwaysTryTypes: true, | ||
| }, | ||
| }, | ||
| }, | ||
| extends: [ | ||
| "plugin:@typescript-eslint/recommended", | ||
| "plugin:import/recommended", | ||
| "plugin:import/typescript", | ||
| ], | ||
| }, | ||
|
|
||
| // Node | ||
| { | ||
| files: [".eslintrc.js"], | ||
| env: { | ||
| node: true, | ||
| }, | ||
| }, | ||
| ], | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,80 @@ | ||
| /** | ||
| * This is intended to be a basic starting point for linting in your app. | ||
| * It relies on recommended configs out of the box for simplicity, but you can | ||
| * and should modify this configuration to best suit your team's needs. | ||
| */ | ||
|
|
||
| /** @type {import('eslint').Linter.Config} */ | ||
| module.exports = { | ||
| extends: ["@remix-run/eslint-config", "@remix-run/eslint-config/node"], | ||
| root: true, | ||
| parserOptions: { | ||
| ecmaVersion: "latest", | ||
| sourceType: "module", | ||
| ecmaFeatures: { | ||
| jsx: true, | ||
| }, | ||
| }, | ||
| env: { | ||
| browser: true, | ||
| commonjs: true, | ||
| es6: true, | ||
| }, | ||
|
|
||
| // Base config | ||
| extends: ["eslint:recommended"], | ||
|
|
||
| overrides: [ | ||
| // React | ||
| { | ||
| files: ["**/*.{js,jsx,ts,tsx}"], | ||
| plugins: ["react", "jsx-a11y"], | ||
| extends: [ | ||
| "plugin:react/recommended", | ||
| "plugin:react/jsx-runtime", | ||
| "plugin:react-hooks/recommended", | ||
| "plugin:jsx-a11y/recommended", | ||
| ], | ||
| settings: { | ||
| react: { | ||
| version: "detect", | ||
| }, | ||
| formComponents: ["Form"], | ||
| linkComponents: [ | ||
| { name: "Link", linkAttribute: "to" }, | ||
| { name: "NavLink", linkAttribute: "to" }, | ||
| ], | ||
| }, | ||
| }, | ||
|
|
||
| // Typescript | ||
| { | ||
| files: ["**/*.{ts,tsx}"], | ||
| plugins: ["@typescript-eslint", "import"], | ||
| parser: "@typescript-eslint/parser", | ||
| settings: { | ||
| "import/internal-regex": "^~/", | ||
| "import/resolver": { | ||
| node: { | ||
| extensions: [".ts", ".tsx"], | ||
| }, | ||
| typescript: { | ||
| alwaysTryTypes: true, | ||
| }, | ||
| }, | ||
| }, | ||
| extends: [ | ||
| "plugin:@typescript-eslint/recommended", | ||
| "plugin:import/recommended", | ||
| "plugin:import/typescript", | ||
| ], | ||
| }, | ||
|
|
||
| // Node | ||
| { | ||
| files: [".eslintrc.js"], | ||
| env: { | ||
| node: true, | ||
| }, | ||
| }, | ||
| ], | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.