chore: shared TS config #10870
chore: shared TS config #10870
Conversation
mjackson
left a comment
mjackson
left a comment
There was a problem hiding this comment.
I'm not opposed to consolidating our tsconfigs. I'd just like to own it for a little while longer instead of introducing deps on @tsconfig/* packages for now.
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "private": true, | |||
| "name": "@remix-run/config", | |||
There was a problem hiding this comment.
Let's call this package @remix-run/tsconfig and keep it in the packages dir (even tho it's private) like everything else.
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "extends": ["@tsconfig/node22/tsconfig.json", "@tsconfig/node-ts/tsconfig.json"], | |||
There was a problem hiding this comment.
Unless you feel strongly about this, I don't see a ton of value in extending these configs. They are small, and we have gotten this far without them. Let's just copy out the pieces we need and own this piece ourselves. I think we already had most of them in our own tsconfigs.
| typescript: ^5.9.3 | ||
|
|
||
| packages: | ||
| - config |
There was a problem hiding this comment.
Let's keep this new package in packages/tsconfig instead of a new root directory.
No description provided.