set node env to production in start script in vite template

[aarbi]

Closes: #

• Docs
• Tests

Testing Strategy:

• fresh remix installation using vite template: npx create-remix@latest --template remix-run/remix/templates/vite
• npm run build
• npm start
  previously this was throwing an error:

  if (!origin) throw Error("Dev server origin not set");
                     ^
Error: Dev server origin not set
    at Object.broadcastDevReady (/Users/aarbi/Batcave/jsnodes/remix/vite/node_modules/.pnpm/@[email protected][email protected]/node_modules/@remix-run/server-runtime/dist/dev.js:17:22)
    at Server.onListen (/Users/aarbi/Batcave/jsnodes/remix/vite/node_modules/.pnpm/@[email protected][email protected]/node_modules/@remix-run/serve/dist/cli.js:123:17)
    at Object.onceWrapper (node:events:632:28)
    at Server.emit (node:events:530:35)
    at emitListeningNT (node:net:1906:10)
    at processTicksAndRejections (node:internal/process/task_queues:81:21)

We should not see this error anymore

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0265e3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[remix-cla-bot]

Hi @aarbi,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[markdalgleish]

I wasn't able to reproduce this issue following your steps. Could you share a minimal repro?

[aarbi]

so I have NODE_ENV=development set on my machine, unsetting that resolved the issue.

Now do we want to enforce the value of it to production for the serve task? if so this MR would still make sense.
I also noticed that this template folder has been removed, and promoted to the main template, so if there are any changes needed here I will move them accordingly